499273 - "Delete Mail Marked as Junk in Folder" action in Tools menu doesn't work.

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[tmark00]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090618 Minefield/3.6a1pre (.NET CLR 3.5.30729)
Build Identifier: Shredder/3.0b3pre Gecko/20090618

"Delete Mail Marked as Junk in Folder" action in Tools menu doesn't work with builds from about last 6 days. No messages in Error Console.


Reproducible: Always

Steps to Reproduce:
1. Go to folder with mail marked as junk
2. Use Delete Mail Marked as Junk in Folder action
3. Nothing happens
Actual Results:  
Nothing

Expected Results:  
Delete junk mail.

All clear.

Comment 1

[Kent James (:rkent)]

Confiming. In a console, I see:

"An error occurred executing the cmd_deleteJunk command. TypeError: gMsgFolderSelected is undefined".

This is probably a regression from bug 474701, which should be tracked in bug 497199. Marking dependency.

Comment 2

[Rain [:rain1] (inactive)]

Attachment: fix all uses of gMsgFolderSelected, v1

plus a couple of basic mozmill tests for junk messages.

Comment 3

[Rain [:rain1] (inactive)]

As for the change in <https://bugzilla.mozilla.org/attachment.cgi?id=384142&action=diff#a/mail/base/content/folderPane.js_sec1>, I tried editing a search folder and it seemed to work.

Comment 5

[Kent James (:rkent)]

I need these fixes to junkCommands.js prior to finishing my bug 496015.

Comment 6

[David :Bienvenu]

Comment on attachment 384142 [details] [diff] [review]
fix all uses of gMsgFolderSelected, v1

as I said over IRC

-    UpdateFolderLocationPicker(gMsgFolderSelected);
+    UpdateFolderLocationPicker(gFolderDisplay.displayedMessage);

this should be gFolderDisplay.displayedFolder;

the mozmill test ran, but it put up the first run prompt that junk stuff does when nothing has been classified, so the mozmill test won't be good for unattended running until that's fixed.

Comment 7

[David :Bienvenu]

nm about the first run prompt; I inadvertently crunched that part of your fix because I needed the rmtree fix to run mozmill at all.

Comment 8

[Rain [:rain1] (inactive)]

Pushed to c-c: http://hg.mozilla.org/comm-central/rev/fac5602f2feb