499438 - mochitest-chrome: test_close_download_manager.xul times out intermittently

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Karl Tomlinson (:karlt)]

6903 ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_close_download_manager.xul | Test timed out.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1245463305.1245470641.23363.gz#err1
Linux mozilla-central unit test on 2009/06/19 19:01:45

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1245465343.1245467340.17574.gz
Linux mozilla-central test everythingelse on 2009/06/19 19:35:43

Comment 2

[Bernd]

again http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1245592150.1245598889.13049.gz

Linux mozilla-central unit test on 2009/06/21 06:49:10

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Again:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1245677837.1245679680.26806.gz

Comment 4

[Robert Strong (they/them - no direct email)]

Linux mozilla-central unit test on 2009/06/23 09:19:44
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1245773984.1245781268.6823.gz&fulltext=1

Comment 5

[Robert Strong (they/them - no direct email)]

Linux mozilla-central unit test on 2009/06/23 21:37:39
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1245818259.1245825254.9458.gz&fulltext=1

6905 INFO Running chrome://mochikit/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_close_download_manager.xul...
6906 INFO TEST-PASS | chrome://mochikit/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_close_download_manager.xul | DMUI closes with ESC key

command timed out: 1200 seconds without output, killing pid 7014
process killed by signal 9

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Linux mozilla-central unit test on 2009/06/24 00:25:34
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1245828334.1245835466.31429.gz#err0

Comment 7

[Shawn Wilsher :sdwilsh]

So, this test wasn't random before, and no download manager code has changed as far as I know.  This seems to have started up a few days after the focus refactoring landed (bug 178324).  Did that maybe change how we handle the closing of windows?

Ted - can you use your magical script and see when this first started to show up please?

Comment 8

[Serge Gautherie (:sgautherie)]

{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1245859601.1245862503.29286.gz
Linux mozilla-central test everythingelse on 2009/06/24 09:06:41

6905 INFO Running chrome://mochikit/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_close_download_manager.xul...
6906 INFO TEST-PASS | chrome://mochikit/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_close_download_manager.xul | DMUI closes with ESC key

command timed out: 1200 seconds without output, killing pid 2232
process killed by signal 9
}

Please, fix or disable tests which abort the suite.

Comment 9

[(not currently active) Ted Mielczarek]

(In reply to comment #7)
> Ted - can you use your magical script and see when this first started to show
> up please?

I updated the db and sent you the URL in #developers. Did you get a chance to look at it?

Comment 10

[Shawn Wilsher :sdwilsh]

I kept getting timeouts and connection resets sadly :(

Comment 11

[Shawn Wilsher :sdwilsh]

Got the results - looks like this started 6/10 when the focus handling refactoring landed.

Comment 12

[Neil Deakin]

Attachment: focus window first

On Linux, window focusing can occur after the load event and other things have occurred.

To fix this we can just call focus() manually on the downloadManagerWindow before sending keys at it.

Comment 13

[Shawn Wilsher :sdwilsh]

Comment on attachment 385163 [details] [diff] [review]
focus window first

r=sdwilsh

Comment 14

[Jesse Ruderman]

Did http://hg.mozilla.org/mozilla-central/rev/704d14a04548 fix this orange?

Comment 15

[Neil Deakin]

Hopefully. Let's reopen if we see it again.