499912 - Crash [@ nsGlobalWindow::ActivateOrDeactivate] when minimizing a chrome window that has documentElement removed

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Martijn Wargers (dead)]

Attachment: test extension

To reproduce, install the test extension attached to this bug.
Then open this url: chrome://test2/content/chromewindow.htm
Then click on the "open chrome window" button
Then minimize the opened chrome window, result: crash.

http://crash-stats.mozilla.com/report/index/506e50e0-b61e-48c3-96e5-2b2072090623?p=1
0  	xul.dll  	nsGlobalWindow::ActivateOrDeactivate  	 dom/base/nsGlobalWindow.cpp:6671
1 	xul.dll 	nsFocusManager::WindowLowered 	dom/base/nsFocusManager.cpp:702
2 	xul.dll 	nsWebShellWindow::HandleEvent 	xpfe/appshell/src/nsWebShellWindow.cpp:433
3 	xul.dll 	nsWindow::DispatchEvent 	widget/src/windows/nsWindow.cpp:966
4 	xul.dll 	nsWindow::DispatchWindowEvent 	widget/src/windows/nsWindow.cpp:986
5 	xul.dll 	nsWindow::DispatchFocus 	widget/src/windows/nsWindow.cpp:6656
6 	xul.dll 	nsWindow::DispatchFocusToTopLevelWindow 	widget/src/windows/nsWindow.cpp:6619
7 	xul.dll 	nsWindow::ProcessMessage 	widget/src/windows/nsWindow.cpp:4713
8 	xul.dll 	nsWindow::WindowProc 	widget/src/windows/nsWindow.cpp:1182
9 	user32.dll 	user32.dll@0x8733 	
10 	user32.dll 	user32.dll@0x8815 	
11 	user32.dll 	user32.dll@0x18e9f 	
12 	user32.dll 	user32.dll@0x18eeb 	
13 	ntdll.dll 	ntdll.dll@0xe472 	
14 	user32.dll 	user32.dll@0x9401 	
15 	xul.dll 	nsAppShell::ProcessNextNativeEvent 	widget/src/windows/nsAppShell.cpp:158
16 	nspr4.dll 	_MD_CURRENT_THREAD 	nsprpub/pr/src/md/windows/w95thred.c:308
17 	winmm.dll 	winmm.dll@0x4e7a

Comment 1

[Neil Deakin]

Attachment: add null check

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 384627 [details] [diff] [review]
add null check

I should have noticed this when reviewing focus rewrite.

Comment 3

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/8db1f8aff01c

Comment 4

[Marco Bonardo [:mak]]

> 5939 ERROR TEST-UNEXPECTED-FAIL | ... | [SimpleTest/SimpleTest.js,
> window.onerror] An error occurred: [ noRootWindow is null ]

this is a persistent error on Linux unittest boxes now