500004 - drag of message from Search Messages fails with error "GetSelectedMessages is not defined" messengerdnd.js Line: 452

Status: VERIFIED FIXED

(MailNews Core :: Search, defect)

Description

[Wayne Mery (:wsmwk)]

Error: GetSelectedMessages is not defined
Source File: chrome://messenger/content/messengerdnd.js
Line: 452

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1pre) Gecko/20090621 Shredder/3.0b3pre

Comment 1

[Rain [:rain1] (inactive)]

Attachment: possible fix

<http://mxr.mozilla.org/comm-central/source/mail/base/content/SearchDialog.js#567> says we don't support drag and drop in the thread pane. Is there a reason to keep messengerdnd.js?

I'd also like to either move messengerdnd.js to suite or get rid of it completely, but this is what I quickly came up with.

Comment 2

[Magnus Melin [:mkmelin]]

That's odd. I'm pretty sure d'n'd from search worked at least in tb3beta2... 
Yeah thunderbird should get rid of messengerdnd.js.

Comment 3

[Wayne Mery (:wsmwk)]

(In reply to comment #1)
> Created an attachment (id=386129) [details]
> possible fix

"possible", as in it's not clear this fixes it?

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to comment #2)
> That's odd. I'm pretty sure d'n'd from search worked at least in tb3beta2... 
> Yeah thunderbird should get rid of messengerdnd.js.

so then we won't need to care about bug 456156, bug 446292 and bug 446288?

Comment 5

[Magnus Melin [:mkmelin]]

(In reply to comment #3)
> "possible", as in it's not clear this fixes it?

As in get's rid of the exception, but dragging doesn't work.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 386129 [details] [diff] [review]
possible fix

Minusing per previous comments.

Comment 7

[Rain [:rain1] (inactive)]

Attachment: proper fix

Straightforward, and works nicely here.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 399094 [details] [diff] [review]
proper fix

yay! r=mkmelin

Comment 9

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/9b7f6edb75fa

Setting in-testsuite? since I hope we'll cover drag/drop in our test suite at some point in the future.

Comment 10

[Rain [:rain1] (inactive)]

Filed bug 515397 about not shipping messengerdnd.js with Thunderbird.

Comment 11

[Wayne Mery (:wsmwk)]

v.fixed 20090909 build. yay! again. Thanks sid.

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)

Are you sure this is related to (bug 497199 ->) bug 474701?

(In reply to comment #2)
> That's odd. I'm pretty sure d'n'd from search worked at least in tb3beta2... 

You sure? It looks like this occurrence was simply missed in bug 414038 comment 116?!

Comment 13

[Magnus Melin [:mkmelin]]

I never verified which bug it's related to, but yeah iirc i verified it worked with beta2