Move messengerdnd.js to suite/

RESOLVED FIXED in Thunderbird 3.0rc1

Status

defect
--
trivial
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: rain1, Assigned: philor)

Tracking

(Blocks 1 bug, {fixed-seamonkey2.0})

Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment)

Assignee

Updated

10 years ago
Component: General → Build Config
Product: Thunderbird → MailNews Core
QA Contact: general → build-config
Summary: Don't ship messengerdnd.js with Thunderbird → Move messengerdnd.js to suite/
Assignee

Comment 1

10 years ago
Posted patch mvSplinter Review
Not sure who'll let me land this when, but it's both harmless and mostly harmless to not land.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #399502 - Flags: review?(kairo)

Comment 2

10 years ago
Actually, I feel somewhat ambiguous about this. For one thing, it would be helpful if you told us that bug 414038 obsoleted it for Thunderbird, but now that I dug that out, I wonder if bug 507601 might actually make it for 2.0 and therefore obsolete and hopefully remove this file altogether.
Depends on: 414038
messenger.xul occurrence: it is expected to be removed by bug 510793.
SearchDialog.xul occurrence: I noticed it but I haven't look at it yet.

jar.mn: this patch seems safe/fine to do in the meantime.

Comment 4

10 years ago
Comment on attachment 399502 [details] [diff] [review]
mv

OK, given Serge, who's doing the work on porting the stuff that obsoleted it on Thunderbird's side, is aware of it and says it's safe for his work, we can do it. I just don't want suite/ to be the collection point for obsolete code ;-)
Attachment #399502 - Flags: review?(kairo) → review+
(In reply to comment #3)
> SearchDialog.xul occurrence: I noticed it but I haven't look at it yet.

Bug 500004 removed it from TB. (I'll discuss SM port there...)
Depends on: 500004
Assignee

Comment 6

10 years ago
(In reply to comment #4)
> I just don't want suite/ to be the collection point for obsolete code ;-)

Nah, that's xpfe/ :)
Assignee

Updated

10 years ago
Whiteboard: [needs approval or branch]
Assignee

Comment 7

10 years ago
Comment on attachment 399502 [details] [diff] [review]
mv

Not quite sure what approval flags I want, so I'll just spam 'em.
Attachment #399502 - Flags: approval-thunderbird3?
Attachment #399502 - Flags: approval-seamonkey2.0?
Attachment #399502 - Flags: approval-thunderbird3?
Attachment #399502 - Flags: approval-thunderbird3+
Attachment #399502 - Flags: approval-seamonkey2.0?
Assignee

Comment 8

10 years ago
http://hg.mozilla.org/comm-central/rev/5be3378df279
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [needs approval or branch]
Target Milestone: --- → Thunderbird 3.0rc1
Severity: normal → trivial
You need to log in before you can comment on or make changes to this bug.