500160 - ./client.py run from the MSYS bash shell fails to checkout LDAP C-SDK

Status: RESOLVED WORKSFORME

(MailNews Core :: Build Config, defect, P5)

Description

[Philip Chee]

STR:
1. cd to the mozilla-build directory and type the command: start-msvc9.bat
2. cd to where the comm-central source has been cloned.
3. type the following command into the MSYS bash shell:
./client.py --skip-comm --skip-mozilla checkout.
4. Result:

"Mozilla tools directory: c:\mozilla-build\"
Visual C++ 6 directory:
Visual C++ 7.1 directory:
Visual C++ 8 directory:
Visual C++ 8 Express directory: C:\Program Files\Microsoft Visual Studio 8\VC\
Visual C++ 9 directory: C:\Program Files\Microsoft Visual Studio 9.0\VC\
Visual C++ 9 Express directory:
Platform SDK directory:
Platform SDK version:
Setting environment for using Microsoft Visual Studio 2008 x86 tools.
Mozilla build environment: MSVC version 9.

Philip@HAIBARA-RAN ~
$ cd /c/hg/comm/

Philip@HAIBARA-RAN /c/hg/comm
$ ./client.py  --skip-comm --skip-mozilla checkout
Executing command: ['hg', 'pull', '-R', '.\\mozilla\\extensions\\inspector', '-r', 'tip']
using http://hg.mozilla.org/dom-inspector/
sending between command
pulling from http://hg.mozilla.org/dom-inspector/
sending capabilities command
capabilities: unbundle=HG10GZ,HG10BZ,HG10UN lookup changegroupsubset
sending lookup command
searching for changes
no changes found
Executing command: ['hg', 'update', '-r', 'default', '-R', '.\\mozilla\\extensions\\inspector']
resolving manifests
 overwrite False partial False
 ancestor 51c6d483a4c1 local 51c6d483a4c1+ remote 51c6d483a4c1
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
Updated to revision 51c6d483a4c15a657df18540219bd0201896c6f2.
CVS checkout begin: 2009-06-24 10:57:10 UTC
Executing command: ['cvs', '-d', ':pserver:[e-mail]:/cvsroot', '-q', 'checkout', '-P', '-r', 'LDAPCSDK_6_0_6B_MOZILLA_RTM', '-d', 'c-sdk', 'mozilla/directory/c-sdk']
 does not match /cvsroot/mozilla/directory/c-sdkla/directory/c-sdk
cvs checkout: ignoring module mozilla/directory/c-sdk
Traceback (most recent call last):
  File "./client.py", line 354, in <module>
    do_cvs_checkout(LDAPCSDK_DIRS, LDAPCSDK_CO_TAG, options.cvsroot, options.cvs, '')
  File "./client.py", line 208, in do_cvs_checkout
    cwd=os.path.join(topsrcdir, checkoutdir, parent))
  File "./client.py", line 54, in check_call_noisy
    check_call(cmd, *args, **kwargs)
  File "c:\dev\python\lib\subprocess.py", line 462, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['cvs', '-d', ':pserver:[e-mail]:/cvsroot', '-q', 'checkout', '-P', '-r', 'LDAPCSDK_6_0_6B_MOZILLA_RTM', '-d', 'c-sdk', 'mozilla/directory/c-sdk']' returned non-zero exit status 1

Philip@HAIBARA-RAN /c/hg/comm
$

Comment 1

[Philip Chee]

Note that all this works fine if I run the following from a CMD.EXE window:
python client.py --skip-comm --skip-mozilla checkout

from the bash shell:
which cvs => /bin/cvs.exe
which python => /c/dev/python/python.exe

Comment 2

[Robert Kaiser]

(In reply to comment #0)
> CVS checkout begin: 2009-06-24 10:57:10 UTC
> Executing command: ['cvs', '-d',
> ':pserver:[e-mail]:/cvsroot', '-q', 'checkout', '-P',
> '-r', 'LDAPCSDK_6_0_6B_MOZILLA_RTM', '-d', 'c-sdk', 'mozilla/directory/c-sdk']
>  does not match /cvsroot/mozilla/directory/c-sdkla/directory/c-sdk
> cvs checkout: ignoring module mozilla/directory/c-sdk

WTF is is "c-sdkla" and where does it come from???

Comment 3

[Philip Chee]

This appears to be a bug in the included version of cvs in mozilla-build.
When I run client.py from the CMD.exe window it is using the cvs.exe from CvsNT I have installed as part of WinCVS. If I prepend the bash patch with the path to the CvsNT version then all works.

Comment 4

[(not currently active) Ted Mielczarek]

We're shipping some old version of CVS in MozillaBuild because the newer version we had broke more things than it fixed. See bug 409260 for details. AFAIK the version we're shipping worked ok though, so I'm not sure what's breaking here.

Comment 5

[Philip Chee]

The CVSNT fork (http://en.wikipedia.org/wiki/CVSNT) is GPL and is actively maintained. Perhaps switching to that will also take care of problems in bug 409260.

Comment 6

[(not currently active) Ted Mielczarek]

As long as it works fine inside msys, yeah, we could do that.

Comment 7

[Philip Chee]

The following works if If I type this into the bash shell (started from start-msvc9.bat):

/bin/cvs -d :pserver:[e-mail]:/cvsroot -q checkout -P -r LDAPCSDK_6_0_6B_MOZILLA_RTM -d c-sdk mozilla/directory/c-sdk

It also works if I use the CVSNT version of cvs.
CVSNT works from within client.py.
The cvs v1.11 that comes with mozilla-build fails from within client.py.
cvs v1.11.22 fails from within client.py.

I am using Python 2.5.2 if this is relevant.

Since this can be trivially worked around by installing CVSNT and putting it ahead of the version in mozilla-build/msys/bin/ setting this bug to P5.

Comment 8

[Justin Wood (:Callek)]

Philip, can you test the following for me please:

mv mozilla/directory/c-sdk mozilla/directory/c-sdk-backup

then:

From inside MSYS
1) run client.py WITHOUT having the CvsNT found in path.
2) repeat (for the update c-sdk path)
3) rm -rf mozilla/directory/c-sdk

Try again from inside a cmd.exe (windows shell)
Try all of the above with JUST WinCVS.

Let me know the result, I have a funny feeling this is just a clash of CVS's issue, but it is one I would like to fix on our end if we can.

Comment 9

[Philip Chee]

I won't be able to get round to this before the end of April. Given that it works fine for me from a CMD shell this isn't a high priority for me.

Comment 10

[Justin Wood (:Callek)]

Ratty, its well past "end of april" shall we reso/WFM or did you intend to do some more digging?

Comment 11

[Philip Chee]

yeah since I've switched to cvsNT I haven't encountered this problem. So I haven't any incentive to dig into this.