500453 - User Adding Tags: simpletests

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Mike Lee]

Breaking out unit tests for bug 494702.

Comment 1

[Mike Lee]

Work in progress. ETA early next week.

Comment 2

[Patrick Sullivan]

Having trouble with all tests that require logging in. In my tests, the session data doesn't persist so the user_id fields. To reproduce, set debug > 0 and run
/en-US/firefox/tests/?case=controllers%2Ftags_controller.test.php

So the test for add_ajax successfully creates the tag, but is not able to create the user_tag_addon row because it needs the user id from the session. I see that the reviews test, testAddReview, fails in the same way.

Any help would be greatly appreciated. The test is in tags_controller.test.php. Once I figure this out I'll be able to write tests for the other controllers.

Comment 3

[Mike Lee]

Will be working on simpletests this weekend.

Comment 4

[Wil Clouser [:clouserw]]

status update?

Comment 5

[Mike Lee]

Still working on these. Have been running into issues. No ETA yet.

Comment 6

[Mike Lee]

Attachment: patch

Code patch (diff file format) for this bug. Same as the one in bug 500452.

Comment 7

[Mike Lee]

Attachment: patch

Updated patch. Also includes tests for blacklist functionality.

Comment 8

[RJ Walsh [:rjwalsh]]

Added in r49293