500687 - reply-all key binding shouldn't be disabled, even in 1-1 messages

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[David Ascher (:davida)]

ctrl-shift-r is mapped to reply-all, so it's what I've trained my fingers to do to avoid the problem of replying to one when i meant to reply to all.

w/ the latest nightlies, reply-all is disabled if it's a message addressed just to me.

I suspect we want to somehow enable the menu item and the keyboard shortcut, even if we don't want the items in the new popup.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

bug 500229 will likely help mitigate this, however this is still a bug.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Sigh.  After all the work I went to to disable those commands...

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Attachment: Make the cmd_replyall track the cmd_reply.

I don't know if we want the button to be active when the command is active.

If we do, how is this different from just always having Reply-All, even when it does nothing?  And should we just always add Reply-All to the reply button (a la News messages)?

If we don't, will we get a lot of confused users asking why the button is disabled, but the menu option is enabled?

Thanks,
Blake.

Comment 4

[Mitra Ardron]

I think we should leave it enabled at all times - some of us almost never use Reply, always use Reply-all, so its confusing to have the button be disabled jsut because there was only one recipient.   I am still replying to ALL the recipients, there just happens to be only one of them.

The keyboard disabling is most annoying since like David I just automatically hit command-shift-R (on a mac) and have to take another action when it doesn't do anything.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 385908 [details] [diff] [review]
Make the cmd_replyall track the cmd_reply.

Yeah I think the reply-all button should also be enabled all the time. 

I don't think there's need to mention the bug # in the code. Just mention it's the special case where reply-all happens to be just one person.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Attachment: Enable the toolbar buttons as well.

> Just mention it's the special case where reply-all happens to be just one person.

Since the command and button are now doing the same thing, I just removed the comment, because it isn't really a special case anymore.

Thanks,
Blake.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 386504 [details] [diff] [review]
Enable the toolbar buttons as well.

Looks good to me! r=mkmelin

Comment 9

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/42f0ff4958e0