Closed Bug 500870 Opened 11 years ago Closed 11 years ago

Add "override" method annotation and enforce that it matches a base class's virtual method

Categories

(Firefox Build System :: Source Code Analysis, enhancement)

enhancement
Not set
normal

Tracking

(status1.9.2 .4-fixed)

RESOLVED FIXED
Tracking Status
status1.9.2 --- .4-fixed

People

(Reporter: jruderman, Assigned: benjamin)

References

Details

(Whiteboard: [fixed-lorentz])

Attachments

(1 file)

Would be nice to be able to annotate methods as intending to overriding a virtual method.  Then, if a base class changes unexpectedly, the derived class will fail to compile instead of mysteriously failing to work properly.
Keywords: student-project
Whiteboard: [good first bug]
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Attachment #401262 - Flags: review?
Keywords: student-project
Whiteboard: [good first bug]
Attachment #401262 - Flags: review? → review?(tglek)
Depends on: 512726
Comment on attachment 401262 [details] [diff] [review]
Add NS_OVERRIDE annotation and enforcement, rev. 1

With following fixed:
signaturesMatch should check shortname instead of doing the check externally.  I did in bug 512726, so lets land this one after that.
Attachment #401262 - Flags: review?(tglek) → review+
Blocks: 517524
http://hg.mozilla.org/mozilla-central/rev/8150d919e280
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blanket approval for Lorentz merge to mozilla-1.9.2
a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.