Closed Bug 517524 Opened 15 years ago Closed 6 years ago

Consider automatically adding NS_OVERRIDE to override methods

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Platform:
x86
Windows NT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: benjamin, Unassigned)

References

Details

How feasible would it be to add the NS_OVERRIDE annotation to existing methods which override a base class method, either using a pork toolchain or a dehydra toolchain and some text processing?
As I mentioned on irc. I think code pollution with attributes is bad. In this case pollution is big and win is minor. My suggestion was to use one of the existing macros to hide the new attribute - NS_IMETHODIMP in particular.
Benjamin doesn't like checking implementation instead of declaration, but I think it's completely natural in this case(and likely to be more efficient).
Product: Core → Firefox Build System
C++ has an actual keyword for this now, and compilers complain if you don't use it.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.