501009 - [Download dialog] "Open" button should be dimmed if no registered handler

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Antonio Gomes (tonikitoo)]

Steps to reproduce:

1) try to download a known unsupported file from fennec. 
e.g. http://download.mozilla.org/?product=firefox-3.0.11&os=win&lang=en-GB

actual outcome:
* although .exe is not a supported mimetype, OPEN button is active and clickable.

expected outcome:
* OPEN option should only active if a supported mime-type is being downloaded.

ps: it used to work after landing bug 455509 and before new download manager landing , bug 436070.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch uses the "hasDefaultHandler" method to check to see if we can actually "open" the file. If not, we disable the "open" button.

Tested and it seems to work

Comment 2

[Antonio Gomes (tonikitoo)]

Comment on attachment 388697 [details] [diff] [review]
patch

r=me (although i am not a official reviewer )

mark, it works fine now. thanks

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed: https://hg.mozilla.org/mobile-browser/rev/fcaaadcb0d14

Comment 4

[Al Billings [:abillings - ex-MoCo]]

Verified with the Maemo build from 8/11/2009.