Closed Bug 501009 Opened 13 years ago Closed 13 years ago

[Download dialog] "Open" button should be dimmed if no registered handler

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Maemo
defect
Not set
normal

Tracking

(fennec1.0+)

VERIFIED FIXED
Tracking Status
fennec 1.0+ ---

People

(Reporter: tonikitoo, Assigned: mfinkle)

References

()

Details

Attachments

(1 file)

Steps to reproduce:

1) try to download a known unsupported file from fennec. 
e.g. http://download.mozilla.org/?product=firefox-3.0.11&os=win&lang=en-GB

actual outcome:
* although .exe is not a supported mimetype, OPEN button is active and clickable.

expected outcome:
* OPEN option should only active if a supported mime-type is being downloaded.

ps: it used to work after landing bug 455509 and before new download manager landing , bug 436070.
Flags: wanted-fennec1.0?
tracking-fennec: --- → 1.0+
Flags: wanted-fennec1.0?
Attached patch patchSplinter Review
This patch uses the "hasDefaultHandler" method to check to see if we can actually "open" the file. If not, we disable the "open" button.

Tested and it seems to work
Assignee: tonikitoo → mark.finkle
Attachment #388697 - Flags: review?(tonikitoo)
Attachment #388697 - Flags: review?(tonikitoo) → review+
Comment on attachment 388697 [details] [diff] [review]
patch

r=me (although i am not a official reviewer )

mark, it works fine now. thanks
pushed: https://hg.mozilla.org/mobile-browser/rev/fcaaadcb0d14
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified with the Maemo build from 8/11/2009.
Status: RESOLVED → VERIFIED
Component: Linux/Maemo → General
QA Contact: maemo-linux → general
You need to log in before you can comment on or make changes to this bug.