501100 - Print preview mochitests should be chrome tests

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

In layout/base/tests we have a few tests that use chrome privileges to put a content IFRAME of a content document into print preview mode. My work in bug 352093 breaks these tests because the print engine doesn't know how to print a document that has no widget. Hacking the print engine to handle that is quite difficult, and pointless since there is no legitimate use for putting an IFRAME of a content document into print preview mode.

So we should convert these tests to chrome tests and run them in a chrome window so that the IFRAME to be printed is a child of chrome, like the browser's print preview. This means we don't need enablePrivilege, which is also nice. It means onload on the iframe doesn't fire, so instead I have the iframe call a function in its parent document.

Comment 1

[Martijn Wargers (dead)]

(In reply to comment #0)
> ... and pointless since there is no legitimate use for putting an IFRAME
> of a content document into print preview mode.

Huh? I'm using that a lot in my testing, actually. Why is there no legitimate use for it? Or do you mean there is currently no legitimate use for it?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I mean there is no real use for it for actual users of the browser (Web developers and chrome/extension developers). I know you do a lot of good testing with it, but you can do that testing using chrome tests (I hope) like the tests I've converted here.

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 385718 [details] [diff] [review]
fix

Sorry for the delay, I had horrible problems with Mercurial.

In bug482976_helper.xul, you add:
+<iframe src="data:text/html;charset=utf-8,&lt;body onload='window.parent.loadedChild()'&gt;"></iframe>
, but the original file, test_bug482976.html, had:
-<iframe onload="SimpleTest.waitForExplicitFinish(); setTimeout(run1, 0); this.removeAttribute('onload')"
-        src="data:text/html,<q>"></iframe>

This is what bug 482976 was about, the fact that <q> tags caused crashes on print preview. So please add that back in your patch.

The tests seem to run fine on my machine, btw.
I'm still looking at the rest.

Comment 4

[Martijn Wargers (dead)]

Comment on attachment 385718 [details] [diff] [review]
fix

The rest looks ok to me.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/292c6e3b45ef

Comment 6

[Martijn Wargers (dead)]

Did you change what I said in comment 3? It seems like you didn't.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I did:
+<iframe src="data:text/html;charset=utf-8,&lt;body onload='window.parent.loadedChild()'&gt;&lt;q&gt;"></iframe>

Comment 8

[Martijn Wargers (dead)]

Sorry, I misread the patch.

Comment 9

[Justin Wood (:Callek)]

A just landed checkin referenced this bug as "followup to Bug 501100" but since the followup was never mentioned here, I'm doing so now: Bug 556686