50167 - window.sidebar undefined; JavaScript returning bad

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P1)

Description

[Millennium]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win95; en-US; m18) Gecko/20000823
BuildID:    2000082313

In JavaScript functions, the "window.sidebar" object is undefined.
As a side effect, it is not possible to add sidebar panels or search engines.

Reproducible: Always
Steps to Reproduce:
1) Go to http://www.rit.edu/~rbg6038/sidebar-test.html

Actual Results:  The page renders as...

The sidebar type is:  undefined
The addPanel type is:
The addSearchEngine type is:

...and errors appear in the JavaScript Console

Expected Results:  The page renders as:


The sidebar type is: object
The addPanel type is: function
The addSearchEngine type is: function

...and no errors appear

Here's the text of the first error that shows up in the console after loading
the page in question (or at least as much as I can fit onto a 1024x768 screen;
the console doesn't want to give me a scrollbar):

Error: [Exception... "Component returned failure code:
0x80004003(NS_ERROR_INVALID_POINTER)[nsIRDFService.GetDataSource]" nsResult:
0x80004003(NS_ERROR_INVALID_POINTER)"location:
Source File: C:\PROGRAM FILES\MOZILLA\SEAMONKEY\components\nsSidebar.js
Line: 65
Column: 0

This appears once for each of the three function calls on the page. The last two
also generate the error: "window.sidebar has no properties" with the source file
being the HTML page.

Comment 1

[Dan Nunn]

confirming 082308, winME

Comment 2

[Dan Nunn]

*** Bug 50196 has been marked as a duplicate of this bug. ***

Comment 3

[Phil Schwartau]

Browser, not engine. Reassigning to DOM Level 0 for further triage -

Comment 4

[Johnny Stenback (:jst)]

Nominating for beta3 and reassigning to the sidebar component owner, I see no
problems in the DOM code, the problem seems to be in the sidebar component, I
get assertions in RDFServiceImpl::GetDataSource()...

Comment 5

[Alex]

Voted and CC'd myself.
This is a major bug and should be fixed asap i have a hunch that this bug is
directly releated to the switch to JAR's

Comment 6

[Dan Nunn]

I agree, this is a major bug. I believe it occured before the switch to Jars 
though. And, it's marked as on all platforms, and jars are only enabled in win32 
so far.

Comment 7

[Claudius Gayle]

nav triage team: [nsbeta3+]

claudius: Isn't this a dupe? This regressed a couple of weeks ago, maybe it's 
filed in one of the JS components?

Comment 8

[verah (gone)]

*** Bug 50581 has been marked as a duplicate of this bug. ***

Comment 9

[Linda Baliman]

From ICP Marketing:

We need the Add Button to work for sidebar evangelism programs which are about
to start in DE, FR, JA

Comment 10

[Katsuhiko Momoi]

Added myself to the CC line.

Comment 11

[Steve Lamm]

I checked in a fix today. One side note, it seems like the sidebar.addPanel(...) 
function requires all three arguments now (title, content_url, customize_url).

Comment 12

[Linda Baliman]

(Naive question)
This is a new requirement, yes?

If the tab does not have a customization URL, how should the third argument be 
coded?  This will affect the Sidebar Dev Guide.

Comment 13

[Katsuhiko Momoi]

I hope a null value for "customize_url" is OK because
most of the partners don't have that url.

Comment 14

[Steve Lamm]

A null value or an empty string is fine for the customize url.

Comment 15

[Katsuhiko Momoi]

Linda, I believe our current documentation has it like this:

window.sidebar.addPanel (document.title, "http://....", "");

so we are probably OK as far as the documentation is concerned.

Comment 16

[shrirang khanzode]

verified this is fixed on win/mac/linux builds 2000090508m18.