502009 - Strip surrounding whitespace from (trim) KB article titles

Status: RESOLVED DUPLICATE of bug 514820

(support.mozilla.org :: Knowledge Base Software, task)

Description

[[:Cww]]

We have a few copies of KB articles with just whitespace around the correct titles:

Eg: (space)Chrome registration failed(space), Firefox n'imprime pas correctement les pages(space).

This is confusing at best.  We should trim whitespace characters either when creating pages/translations or when saving them

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

This updates the create_page function for tikilib.php
Cheng, can you file an SQL patch to follow for updating current articles?

Comment 2

[[:Cww]]

Attachment: article titles with whitespace

I think we probably want to do this manually since we shouldn't just overwrite existing articles with their duplicates.  Attaching a list of all articles with surrounding whitespace.

Comment 3

[Laura Thomson :laura]

Comment on attachment 386565 [details] [diff] [review]
patch, v1

trim() is not mb safe.

Comment 4

[Paul Craciunoiu [:paulc]]

(In reply to comment #3)
> (From update of attachment 386565 [details] [diff] [review])
> trim() is not mb safe.
Is there a good approach for this? Would regex be mb safe for replacing spaces at the beginning and end of string?

Comment 5

[Paul Craciunoiu [:paulc]]

(In reply to comment #4)
> Is there a good approach for this? Would regex be mb safe for replacing spaces
> at the beginning and end of string?
Nevermind. As part of bug 501880 (newsearch rewrite), I have added a multibyte library file, including a multibyte version of trim (mb_trim), which will take care of this bug. Pushing to 1.4 and adding dependence.

Comment 6

[Paul Craciunoiu [:paulc]]

Since this is in tikilib, let's try to fix this on a larger scale, as part of bug 514820.