508303 - Need mb library for SUMO

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect)

Description

[Paul Craciunoiu [:paulc]]

There's a lot of places on SUMO where we use trim(). Since we're dealing with multi-byte characters, we should have a mb_trim() function and use that instead, it's safer. Same goes for a few other functions, such as str_replace()

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

FTR, I plan to use this in the newsearch rewrite part of ForumUX. So no need to review this yet, as it's not being used anywhere.

Comment 2

[Paul Craciunoiu [:paulc]]

We could make this part of 1.3 and replace trim() with mb_trim() pretty much everywhere. What do you think, Laura?

Comment 3

[Paul Craciunoiu [:paulc]]

r50947 / r50948

QA: Nothing to verify here, but we will use these multi byte friendly functions to trim whitespace from strings in the future.

Comment 4

[Paul Craciunoiu [:paulc]]

Comment on attachment 392529 [details] [diff] [review]
patch, v1

Just going through my r? list

Comment 5

[James Socol [:jsocol, :james]]

Not sure why tiki_discuss was added here.