502616 - Fix css for tab images (loading/busy/opacity)

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I was looking at our tab icon implementation earlier and found various issues, so I've rolled them into one as they are all pretty much the same broken theme code:

1) For tab-image-middle, tabmailBindings.xml creates a xul:stack with class tab-icon and within that two images one with class tab-icon-image, the other with tab-extra-status.

We don't use tab-extra-status anywhere (and I don't see why we should either).

2) Possibly as a result of 1), the Mac css is broken. It is assuming it can put styles on the tab-icon xul:stack rather than the tab-icon-image and is currently has the issues that:

- The tab busy indication doesn't get shown.
- The opacity of the icon is always .6. On Firefox the opacity is .6 when a tab is deselected, when it is a select tab or you hover over it, then the opacity is removed.

I'm pretty sure this functionality was intended in bug 462952 though as I'm looking at FF 3.5 rather than 3.0 something may have changed in the meantime.

3) On Windows, the loading image doesn't get seen even though the normal icon disappears for a bit. This is because the folder icons are using moz-image-region and the region gets set incorrectly as a result.

The attached patch fixes the above points, I'm currently double-checking linux (although I think that does actually work).

Comment 1

[Mark Banner (:standard8)]

Attachment: Windows and Mac fix.

Ok, so when they switched to using background-image rather than list-style-image in bug 483759 comment 22, it broke linux in that you get the busy indicator shown on top of the folder indicator :-(

So we're kinda broken on all 3 platforms (in different ways). Whilst I try and figure out linux, here's the fix I'm proposing for Windows and Mac, comments welcome.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

and ever since that change for linux I've been wishing we just lost the little star icon for folders and used a color change for the text like the Mac does.

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 387026 [details] [diff] [review]
Windows and Mac fix.

Looks good to me.

Comment 4

[Mark Banner (:standard8)]

Attachment: [checked in] Windows and Mac fix v2

The last version of this patch still included the linux changes. This is what I am checking in.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 389354 [details] [diff] [review]
[checked in] Windows and Mac fix v2

Checked in: http://hg.mozilla.org/comm-central/rev/2d54a48c8a72

Comment 6

[Mark Banner (:standard8)]

AFAICT the linux issues no longer exist, so this is fixed/wfm