Refactor the widget icon creation code

RESOLVED FIXED

Status

()

Core
Widget: Win32
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: robarnold, Assigned: robarnold)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 387058 [details] [diff] [review]
v1.0

nsWindow contains some code to create HICON/HCURSORs from imgIContainers. This patch moves this functionality and helper functions into nsWindowGfx so that other modules within widget can use this (namely the Windows 7 taskbar preview code).
Attachment #387058 - Flags: review?(vladimir)
(Assignee)

Updated

9 years ago
Attachment #387058 - Flags: review?(jmathies)
(Assignee)

Updated

9 years ago
Status: NEW → ASSIGNED

Updated

9 years ago
Attachment #387058 - Flags: review?(jmathies) → review+

Comment 1

9 years ago
Comment on attachment 387058 [details] [diff] [review]
v1.0

Sweet!

Curious though, do we really need to be explicit in the naming - CreateHICON vs. CreateWinIcon or just CreateIcon?
(Assignee)

Comment 2

9 years ago
Comment on attachment 387058 [details] [diff] [review]
v1.0

I could rename it to CreateIcon but since it's used for cursors that seems misleading (and HICON is slightly less misleading)
Attachment #387058 - Flags: review?(vladimir)
(Assignee)

Comment 3

8 years ago
Created attachment 389792 [details] [diff] [review]
v1.1

Seems I did rename it in my local tree (maybe we talked about this over IRC?)
Assignee: nobody → tellrob
Attachment #387058 - Attachment is obsolete: true
(Assignee)

Comment 4

8 years ago
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/fef11a3cdca7
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Depends on: 541182
You need to log in before you can comment on or make changes to this bug.