Closed
Bug 502710
Opened 15 years ago
Closed 15 years ago
Refactor the widget icon creation code
Categories
(Core :: Widget: Win32, defect)
Core
Widget: Win32
Tracking
()
RESOLVED
FIXED
People
(Reporter: robarnold, Assigned: robarnold)
References
Details
Attachments
(1 file, 1 obsolete file)
|
15.45 KB,
patch
|
Details | Diff | Splinter Review |
nsWindow contains some code to create HICON/HCURSORs from imgIContainers. This patch moves this functionality and helper functions into nsWindowGfx so that other modules within widget can use this (namely the Windows 7 taskbar preview code).
Attachment #387058 -
Flags: review?(vladimir)
|
Assignee | |
Updated•15 years ago
|
Attachment #387058 -
Flags: review?(jmathies)
|
|
Assignee | |
Updated•15 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•15 years ago
|
Attachment #387058 -
Flags: review?(jmathies) → review+
|
|
||
Comment 1•15 years ago
|
||
Comment on attachment 387058 [details] [diff] [review]
v1.0
Sweet!
Curious though, do we really need to be explicit in the naming - CreateHICON vs. CreateWinIcon or just CreateIcon?
|
|
Assignee | |
Comment 2•15 years ago
|
||
Comment on attachment 387058 [details] [diff] [review]
v1.0
I could rename it to CreateIcon but since it's used for cursors that seems misleading (and HICON is slightly less misleading)
Attachment #387058 -
Flags: review?(vladimir)
|
|
Assignee | |
Comment 3•15 years ago
|
||
Seems I did rename it in my local tree (maybe we talked about this over IRC?)
Assignee: nobody → tellrob
Attachment #387058 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•15 years ago
|
||
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/fef11a3cdca7
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•