Closed Bug 502710 Opened 15 years ago Closed 15 years ago

Refactor the widget icon creation code

Categories

(Core :: Widget: Win32, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: robarnold, Assigned: robarnold)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch v1.0 (obsolete) — Splinter Review
nsWindow contains some code to create HICON/HCURSORs from imgIContainers. This patch moves this functionality and helper functions into nsWindowGfx so that other modules within widget can use this (namely the Windows 7 taskbar preview code).
Attachment #387058 - Flags: review?(vladimir)
Attachment #387058 - Flags: review?(jmathies)
Status: NEW → ASSIGNED
Attachment #387058 - Flags: review?(jmathies) → review+
Comment on attachment 387058 [details] [diff] [review]
v1.0

Sweet!

Curious though, do we really need to be explicit in the naming - CreateHICON vs. CreateWinIcon or just CreateIcon?
Comment on attachment 387058 [details] [diff] [review]
v1.0

I could rename it to CreateIcon but since it's used for cursors that seems misleading (and HICON is slightly less misleading)
Attachment #387058 - Flags: review?(vladimir)
Attached patch v1.1Splinter Review
Seems I did rename it in my local tree (maybe we talked about this over IRC?)
Assignee: nobody → tellrob
Attachment #387058 - Attachment is obsolete: true
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/fef11a3cdca7
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Depends on: 541182
You need to log in before you can comment on or make changes to this bug.