Closed Bug 502723 Opened 16 years ago Closed 16 years ago

updater checks the wrong MAX_PATH define

Categories

(Toolkit :: Application Update, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.1 --- .2-fixed

People

(Reporter: mook, Assigned: nick.kreeger)

References

()

Details

(Keywords: fixed1.9.0.14, verified1.9.1)

Attachments

(1 file)

See URL; it checks for _MAX_PATH being defined and proceeds to use MAX_PATH (note lack of leading underscore).
Attached patch Patch V1Splinter Review
Comment on attachment 387073 [details] [diff] [review] Patch V1 This is a dupe of bug 501800 but this way I can review it to get this fixed sooner rather than later. r=me
Attachment #387073 - Flags: review+
(In reply to comment #2) > (From update of attachment 387073 [details] [diff] [review]) > This is a dupe of bug 501800 but this way I can review it to get this fixed > sooner rather than later. r=me Ok cool, should I ask for a SR?
No need for sr on this
Blocks: 412610
changeset: 30011:a5dfd04812d8 tag: tip user: Nick Kreeger <nick.kreeger@park.edu> date: Mon Jul 06 15:31:23 2009 -0700 summary: Fixing bug 502723 - updater checks the wrong MAX_PATH define. changeset: 30042:475b8583efe4 tag: tip parent: 30011:a5dfd04812d8 parent: 30041:a5b215383e58 user: Nick Kreeger <nick.kreeger@park.edu> date: Mon Jul 06 15:32:29 2009 -0700 summary: Merging patch for bug 502723. Pushed to mozilla central. Thank you Rob!
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment on attachment 387073 [details] [diff] [review] Patch V1 Requesting approval for inclusion of this typo-fix in 1.9.1 & 1.9.0.
Attachment #387073 - Flags: approval1.9.1?
Attachment #387073 - Flags: approval1.9.0.13?
Version: unspecified → Trunk
Assignee: nobody → nick.kreeger
Comment on attachment 387073 [details] [diff] [review] Patch V1 Approved for 1.9.0.13, a=dveditz for release-drivers
Attachment #387073 - Flags: approval1.9.0.13? → approval1.9.0.13+
Comment on attachment 387073 [details] [diff] [review] Patch V1 Approved for 1.9.1.1. a=ss
Attachment #387073 - Flags: approval1.9.1? → approval1.9.1.1+
Comment on attachment 387073 [details] [diff] [review] Patch V1 We're firedrilling for 1.9.1.1, so this will have to wait for 1.9.1.2
Attachment #387073 - Flags: approval1.9.1.2+
Attachment #387073 - Flags: approval1.9.1.1-
Attachment #387073 - Flags: approval1.9.1.1+
Checked in to CVS for 1.9.0.13 Checking in mozilla/toolkit/mozapps/update/src/updater/updater.cpp; /cvsroot/mozilla/toolkit/mozapps/update/src/updater/updater.cpp,v <-- updater. cpp new revision: 1.41; previous revision: 1.40 done
Keywords: fixed1.9.0.13
Is there a way to verify this on 3.5.2?
Except by code inspection no.
I can see the change in mozilla-1.9.1 pulled two hours ago. Based on comment 14, marking verified1.9.1
Keywords: verified1.9.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: