Closed
Bug 502723
Opened 16 years ago
Closed 16 years ago
updater checks the wrong MAX_PATH define
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.1 | --- | .2-fixed |
People
(Reporter: mook, Assigned: nick.kreeger)
References
()
Details
(Keywords: fixed1.9.0.14, verified1.9.1)
Attachments
(1 file)
655 bytes,
patch
|
robert.strong.bugs
:
review+
beltzner
:
approval1.9.1.1-
beltzner
:
approval1.9.1.2+
dveditz
:
approval1.9.0.14+
|
Details | Diff | Splinter Review |
See URL; it checks for _MAX_PATH being defined and proceeds to use MAX_PATH (note lack of leading underscore).
Assignee | ||
Comment 1•16 years ago
|
||
![]() |
||
Comment 2•16 years ago
|
||
Comment on attachment 387073 [details] [diff] [review]
Patch V1
This is a dupe of bug 501800 but this way I can review it to get this fixed sooner rather than later. r=me
Attachment #387073 -
Flags: review+
Assignee | ||
Comment 4•16 years ago
|
||
(In reply to comment #2)
> (From update of attachment 387073 [details] [diff] [review])
> This is a dupe of bug 501800 but this way I can review it to get this fixed
> sooner rather than later. r=me
Ok cool, should I ask for a SR?
Assignee | ||
Comment 6•16 years ago
|
||
changeset: 30011:a5dfd04812d8
tag: tip
user: Nick Kreeger <nick.kreeger@park.edu>
date: Mon Jul 06 15:31:23 2009 -0700
summary: Fixing bug 502723 - updater checks the wrong MAX_PATH define.
changeset: 30042:475b8583efe4
tag: tip
parent: 30011:a5dfd04812d8
parent: 30041:a5b215383e58
user: Nick Kreeger <nick.kreeger@park.edu>
date: Mon Jul 06 15:32:29 2009 -0700
summary: Merging patch for bug 502723.
Pushed to mozilla central. Thank you Rob!
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 7•16 years ago
|
||
Comment on attachment 387073 [details] [diff] [review]
Patch V1
Requesting approval for inclusion of this typo-fix in 1.9.1 & 1.9.0.
Attachment #387073 -
Flags: approval1.9.1?
Attachment #387073 -
Flags: approval1.9.0.13?
Updated•16 years ago
|
Version: unspecified → Trunk
Updated•16 years ago
|
Assignee: nobody → nick.kreeger
Comment 8•16 years ago
|
||
Comment on attachment 387073 [details] [diff] [review]
Patch V1
Approved for 1.9.0.13, a=dveditz for release-drivers
Attachment #387073 -
Flags: approval1.9.0.13? → approval1.9.0.13+
Comment 9•16 years ago
|
||
Comment on attachment 387073 [details] [diff] [review]
Patch V1
Approved for 1.9.1.1. a=ss
Attachment #387073 -
Flags: approval1.9.1? → approval1.9.1.1+
Comment 10•16 years ago
|
||
Comment on attachment 387073 [details] [diff] [review]
Patch V1
We're firedrilling for 1.9.1.1, so this will have to wait for 1.9.1.2
Attachment #387073 -
Flags: approval1.9.1.2+
Attachment #387073 -
Flags: approval1.9.1.1-
Attachment #387073 -
Flags: approval1.9.1.1+
![]() |
||
Comment 11•16 years ago
|
||
Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1c9b8efa0821
status1.9.1:
--- → .2-fixed
![]() |
||
Comment 12•16 years ago
|
||
Checked in to CVS for 1.9.0.13
Checking in mozilla/toolkit/mozapps/update/src/updater/updater.cpp;
/cvsroot/mozilla/toolkit/mozapps/update/src/updater/updater.cpp,v <-- updater.
cpp
new revision: 1.41; previous revision: 1.40
done
Keywords: fixed1.9.0.13
Comment 13•16 years ago
|
||
Is there a way to verify this on 3.5.2?
![]() |
||
Comment 14•16 years ago
|
||
Except by code inspection no.
Comment 15•16 years ago
|
||
I can see the change in mozilla-1.9.1 pulled two hours ago. Based on comment 14, marking verified1.9.1
Keywords: verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•