502907 - Allow for the registration of cleanup functions that run when the harness is done

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, enhancement)

Description

[Shawn Wilsher :sdwilsh]

Allow for the registration of cleanup functions that run when the harness is done so we can clean up at a sane time.

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 387255 [details] [diff] [review]
v1.0

I know I told you I wanted this patch, but at the same time, looking at the code, it appears that the harness doesn't load the tail files until after all the tests are finished. (Note that your code is added right below that _load_files call!)

I think the tail files should work for what you need, instead.

(Otherwise, technically, the patch looks fine.)

Comment 3

[Jeff Walden [:Waldo]]

Tail files used to be immediately loaded as if at the end of the command line, that changed recently.  That said, I think I prefer this explicit finalization registration API to tail_*.js, and I probably would be in favor of removing the latter completely.  We could share the functions in head_*.js, which feels sufficient to me.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 387255 [details] [diff] [review]
v1.0

No wonder I was confused. I must not have actually looked at Serge's patch there. After thinking about it, I agree with Jeff. Shawn: can you file a followup on migrating existing tail_*.js users to this API?

Comment 5

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/c7a952a3bb78

Filed bug 503613 for removing tail_ file usage.

Comment 6

[Marco Bonardo [:mak]]

since i was in need of this
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/90f2a65e77ef