Closed
Bug 502907
Opened 16 years ago
Closed 16 years ago
Allow for the registration of cleanup functions that run when the harness is done
Categories
(Testing :: XPCShell Harness, enhancement)
Testing
XPCShell Harness
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1.6])
Attachments
(1 file)
1.05 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Allow for the registration of cleanup functions that run when the harness is done so we can clean up at a sane time.
Assignee | ||
Comment 1•16 years ago
|
||
Attachment #387255 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•16 years ago
|
Whiteboard: [needs review ted]
Comment 2•16 years ago
|
||
Comment on attachment 387255 [details] [diff] [review]
v1.0
I know I told you I wanted this patch, but at the same time, looking at the code, it appears that the harness doesn't load the tail files until after all the tests are finished. (Note that your code is added right below that _load_files call!)
I think the tail files should work for what you need, instead.
(Otherwise, technically, the patch looks fine.)
Attachment #387255 -
Flags: review?(ted.mielczarek) → review-
Comment 3•16 years ago
|
||
Tail files used to be immediately loaded as if at the end of the command line, that changed recently. That said, I think I prefer this explicit finalization registration API to tail_*.js, and I probably would be in favor of removing the latter completely. We could share the functions in head_*.js, which feels sufficient to me.
Comment 4•16 years ago
|
||
Comment on attachment 387255 [details] [diff] [review]
v1.0
No wonder I was confused. I must not have actually looked at Serge's patch there. After thinking about it, I agree with Jeff. Shawn: can you file a followup on migrating existing tail_*.js users to this API?
Attachment #387255 -
Flags: review- → review+
Assignee | ||
Updated•16 years ago
|
Whiteboard: [needs review ted]
Assignee | ||
Comment 5•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c7a952a3bb78
Filed bug 503613 for removing tail_ file usage.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•16 years ago
|
Target Milestone: --- → mozilla1.9.2a1
Updated•16 years ago
|
Severity: normal → enhancement
Flags: in-testsuite?
Whiteboard: [needs 1.9.1.x landing]
Comment 6•15 years ago
|
||
since i was in need of this
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/90f2a65e77ef
Keywords: fixed1.9.1
Whiteboard: [needs 1.9.1.x landing]
Updated•15 years ago
|
Whiteboard: [fixed1.9.1.6]
You need to log in
before you can comment on or make changes to this bug.
Description
•