Stop using tail_ files in xpcshell: use do_register_cleanup() instead

RESOLVED FIXED in Firefox 53

Status

defect
--
trivial
RESOLVED FIXED
10 years ago
3 years ago

People

(Reporter: sdwilsh, Assigned: standard8)

Tracking

(Blocks 1 bug, {dev-doc-complete, meta})

Trunk
mozilla53
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [Waiting for blocking bugs] [Av1: fixed1.9.3a1 fixed1.9.2b1 fixed1.9.1.4], )

Attachments

(3 attachments)

Whiteboard: [good first bug]
Blocks: 490147
Severity: normal → trivial
Depends on: 502909
Flags: in-testsuite-
Keywords: meta
OS: Mac OS X → All
Hardware: x86 → All
Summary: Stop using tail_ files in xpcshell. Use do_register_cleanup instead. → Stop using tail_ files in xpcshell: use do_register_cleanup() instead
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #388053 - Flags: review?(jwalden+bmo)
Depends on: 503662
Attachment #388053 - Flags: review?(ted.mielczarek)
Comment on attachment 388053 [details] [diff] [review]
(Av1) Drop "empty" xpcshell tail.js
[Checkin: See comment 3 & 4 & 5]

>     cmdT = ", ".join(['"' + f.replace('\\', '/') + '"'
>-                       for f in (testTailFiles + xpcsTailFile)])
>+                       for f in (testTailFiles)])

Nix the unnecessary parens, just like in the previous statement for testHeadFiles.
Attachment #388053 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 388053 [details] [diff] [review]
(Av1) Drop "empty" xpcshell tail.js
[Checkin: See comment 3 & 4 & 5]


http://hg.mozilla.org/mozilla-central/rev/250248bebc42
Av1, with comment 2 suggestion(s).
Attachment #388053 - Attachment description: (Av1) Drop "empty" xpcshell tail.js → (Av1) Drop "empty" xpcshell tail.js [Checkin: See comment 3]
Attachment #388053 - Flags: review?(ted.mielczarek)
Keywords: helpwanted
Whiteboard: [good first bug] → [good first bug] [ToDo: file blocking bugs]
Comment on attachment 388053 [details] [diff] [review]
(Av1) Drop "empty" xpcshell tail.js
[Checkin: See comment 3 & 4 & 5]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3753f32f45ca
Attachment #388053 - Attachment description: (Av1) Drop "empty" xpcshell tail.js [Checkin: See comment 3] → (Av1) Drop "empty" xpcshell tail.js [Checkin: See comment 3 & 4]
Keywords: checkin-needed
Whiteboard: [good first bug] [ToDo: file blocking bugs] → [c-n: Av1 to m-1.9.2] [good first bug] [ToDo: file blocking bugs]
Comment on attachment 388053 [details] [diff] [review]
(Av1) Drop "empty" xpcshell tail.js
[Checkin: See comment 3 & 4 & 5]


http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9388ec6329d6
Attachment #388053 - Attachment description: (Av1) Drop "empty" xpcshell tail.js [Checkin: See comment 3 & 4] → (Av1) Drop "empty" xpcshell tail.js [Checkin: See comment 3 & 4 & 5]
Keywords: checkin-needed
Whiteboard: [c-n: Av1 to m-1.9.2] [good first bug] [ToDo: file blocking bugs] → [good first bug] [ToDo: file blocking bugs] [Av1: fixed1.9.3a1 fixed1.9.2b1 fixed1.9.1.3]
Whiteboard: [good first bug] [ToDo: file blocking bugs] [Av1: fixed1.9.3a1 fixed1.9.2b1 fixed1.9.1.3] → [good first bug] [ToDo: file blocking bugs] [Av1: fixed1.9.3a1 fixed1.9.2b1 fixed1.9.1.4]
Depends on: 527444
Keywords: helpwanted
Whiteboard: [good first bug] [ToDo: file blocking bugs] [Av1: fixed1.9.3a1 fixed1.9.2b1 fixed1.9.1.4] → [Waiting for blocking bugs] [Av1: fixed1.9.3a1 fixed1.9.2b1 fixed1.9.1.4]
No longer depends on: 502909
Stealing, as I've been working on the dependent bugs, and I'm not sure Serge is around any more. Hopefully will have a patch for this next week.
Assignee: bugzillamozillaorg_serge_20140323 → standard8
For reference, the command I used to remove all the tail lines was:

$ find . -name 'xpcshell.ini' -exec sed -i '' '/tail[ ]*=/d' {} \;
Comment on attachment 8827504 [details]
Bug 503613 - Remove the tail file functionality from xpcshell.

https://reviewboard.mozilla.org/r/105164/#review106534

This patch made my day. Thank you for cleaning up this cruft.
Attachment #8827504 - Flags: review?(gps) → review+
Comment on attachment 8827840 [details]
Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files.

https://reviewboard.mozilla.org/r/105434/#review106536

I'm crying tears of joy.
Attachment #8827840 - Flags: review?(gps) → review+
Comment on attachment 8827504 [details]
Bug 503613 - Remove the tail file functionality from xpcshell.

https://reviewboard.mozilla.org/r/105164/#review106548

A try push was not happy with this change: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e2120177b3b

On the positive side, the failure broke the Treeherder error parser. So, achievement unlocked!
Attachment #8827504 - Flags: review+ → review-
Thanks for running it through try, I'd totally forgotten about that. Hopefully the updated patch will pass now :-)
Comment on attachment 8827504 [details]
Bug 503613 - Remove the tail file functionality from xpcshell.

https://reviewboard.mozilla.org/r/105164/#review106820

\o/

It looks like Try it happy, so I'll land this for you.
Attachment #8827504 - Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f385b42d565e
Remove the tail file functionality from xpcshell; r=gps
https://hg.mozilla.org/integration/autoland/rev/6eda6d7d78f1
Remove old 'tail =' lines from xpcshell.ini files; r=gps
https://hg.mozilla.org/mozilla-central/rev/f385b42d565e
https://hg.mozilla.org/mozilla-central/rev/6eda6d7d78f1
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Blocks: 1311312
As a side note, since it will be used more, I filed (with a patch) Bug 1332295 - do_register_cleanup should support generators
You need to log in before you can comment on or make changes to this bug.