503033 - Contributions page does not accept non-en-US decimal points

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[Fred Wenzel [:wenzel]]

Attachment: Screenshot

See attached screenshot: When setting up contributions, the localized decimal point should be supported.

I suggest we always support the dot, and in addition to that allow whatever the local decimal point is (in German, that would be a comma). localeconv [1] knows.

Marking this major, because non-English users will stumble across this almost inevitably.

[1] http://us2.php.net/manual/en/function.localeconv.php

Comment 1

[Fred Wenzel [:wenzel]]

In fact, I am unsure why we use a regex for valid money? is_numeric does the separator-thing automatically. Note though that it would not support the point anymore if the correct one for your locale is a comma. May need to str_replace the point to the appropriate local decimal separator before checking with is_numeric.

Comment 2

[Wil Clouser [:clouserw]]

We're only supporting USD for this initial launch as we're just testing it out.  I thought there was a "(USD)" label after the box but apparently not.

Would adding that label be enough for people to realize they need to use decimal points?

Comment 3

[Fred Wenzel [:wenzel]]

Sorry, don't want to sound self-centered, but I don't think all people know that English-speaking countries use a point as a decimal point. I could change the German error message for invalid numbers so that it shows "0.00", which would hopefully make people realize that they need to write it like that, but it feels like a duct-tape fix to me :-/

From what I can tell, however, all other localizers that have translated the string preserved the decimal point rather than localizing the value.

I'll change it in the German l10n, but I'd feel bad calling the issue FIXED after this...

Comment 4

[Fred Wenzel [:wenzel]]

I changed it to "0.00" etc in de: r29515.

Comment 5

[Wil Clouser [:clouserw]]

Jeff added an example in r29519.  Since we're only supporting USD for this run I'm calling this fixed (or wontfix if you like).  If/when we support other currencies we'll make the system more robust, including accepting appropriate decimal points.

Comment 6

[fcp]

(In reply to comment #5)
> Jeff added an example in r29519.  Since we're only supporting USD for this run
> I'm calling this fixed (or wontfix if you like).  If/when we support other
> currencies we'll make the system more robust, including accepting appropriate
> decimal points.

Although I was a bad student in the German class, I would like to point out that the fact that USD is the only supported currency here has nothing to do with this issue.  In some languages including German, the decimal separator in a number is represented by a comma no matter which unit the number is in.  This is just in the same way that we do not write “12,34 EUR” in the American/British English.
See e.g. http://news.google.com/news?ned=de&hl=de&q=USD

For now, the current hack (writing “0.00”) is probably much better than no hack.  But I wish that this bug will be really fixed in future.

> msgstr "Sollte eine positive Zahl zwischen 0.00 and 99.99 sein."
and -> und?

Comment 7

[Fred Wenzel [:wenzel]]

(In reply to comment #6)
> > msgstr "Sollte eine positive Zahl zwischen 0.00 and 99.99 sein."
> and -> und?

Haha, wow, thanks ;) r29546.

I also agree that this has nothing to do with the currency. Commas stay commas :)

Wil, should we add this to an upcoming milestone? I can probably write a simple patch.

Comment 8

[Wil Clouser [:clouserw]]

if you like

Comment 9

[Fred Wenzel [:wenzel]]

(In reply to comment #8)
> if you like

Oh, you know I do.

Comment 10

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

This patch converts localized "commas" to the point we currently require on the fly.

Comment 11

[Wil Clouser [:clouserw]]

Comment on attachment 389913 [details] [diff] [review]
Patch, rev. 1

typo: $local_info

Comment 12

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 2

Whoops. Thanks.

Comment 13

[Fred Wenzel [:wenzel]]

r30240, thanks.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot, showing "1,25" as the suggested value

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot, part deux, showing that "1,25" gets rewritten as "1.25"

Is it expected that, even on /de/, the "1,25" I entered gets normalized back to "1.25"?

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED per the scope of this bug and comment 14; comment 15, if desired, should be a separate bug.

Comment 17

[Fred Wenzel [:wenzel]]

(In reply to comment #16)
> Verified FIXED per the scope of this bug and comment 14; comment 15, if
> desired, should be a separate bug.

I agree, thanks. For the scope of this bug, normalizing back to '.' is expected. I intentionally wanted to allow localized decimal points to be *entered* without screwing with the PayPal side of things.

Choosing the right decimal point when displaying it on the page, that is probably indeed another bug.