503146 - Remove "2.0" from "Show content customized for:"

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

We're not supporting Firefox 2 anymore. On some articles where the markup is complex, the Firefox2 content has been removed to make it easier for contributors. "2.0" should no longer be displayed in the "Show content customized for:" section of articles.

NOTE: SHOWFOR support for Firefox 2 should not be removed. This is just about removing the "2.0" from "Show content customized for:".

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

This patch comments out Firefox 2 from "possible browser" (one line change), and updates the ordering of the <li> items in the browser list to display hidden items last. The latter was necessary because the css styling appended a "|" before 3.0 after it was removed - does not change functionality and it is better practice to place the hidden list items at the end anyway :)

Comment 2

[Chris Ilias [:cilias]]

Can we get a screenshot of this? I wanted to create a mockup for this bug using Firebug, but noticed that there were alignment issues after removing the "2.0 |". Just an aesthetics thing.

Comment 3

[Paul Craciunoiu [:paulc]]

Attachment: demo screenshot for patch v1

Comment 4

[Chris Ilias [:cilias]]

David, Stephen, does that alignment look like a bug to you? I don't know. It looks bad to me, but I'm not sure if it's worth blocking this bug.

Comment 5

[David Tenser [:djst]]

What part of the alignment is it that you think looks bad? The (tiny) screenshot doesn't really show any alignment problems to me.

Comment 6

[Chris Ilias [:cilias]]

i would say it's the vertical alignment that looks bad. And the empty space in the bottom right. But if it's something that others don't notice, it's not worth blocking this bug. :-)

Comment 7

[David Tenser [:djst]]

If someone could provide a larger screenshot, I might be able to tell, but based on the thumbnail-ish screenshot it looks OK.

Comment 8

[Paul Craciunoiu [:paulc]]

Attachment: demo full article

Here's a full article screenshot.

Comment 9

[Laura Thomson :laura]

Comment on attachment 388810 [details] [diff] [review]
patch, v1

I don't see the alignment problem?  but we may need to fix depending on what cilias says.

Comment 10

[Chris Ilias [:cilias]]

Considering that no-one else sees an alignment problem, let's go with the current patch.

Comment 11

[Paul Craciunoiu [:paulc]]

r30474 / r30475

Comment 12

[Tom Ellins [:TMZ]]

Verified 2.0 is not shown on http://support-stage.mozilla.org/en-US/kb/Clearing+Location+bar+history?s=cannot+clear+location+bar+history

Comment 13

[Paul Craciunoiu [:paulc]]

Are we going to do anything about the content? Visitors will be unable to see it, so are we keeping it for archive purposes?

Comment 14

[[:Cww]]

We have page history so no need to keep anything for archiving.  If users can't see it, we should delete it (this will not be trivial to do automatically) so that localisers don't get confused about translating it.

Comment 15

[Chris Ilias [:cilias]]

With regards to content, the policy is that we don't need to spend any resource on removing it. After this bug is implemented, the only affect the 2.0 content is going to have is that some articles will have some unnecessarily complex markup. And in those cases, any contributor can just remove it when they are updating the article for any other reason.

Comment 16

[David Tenser [:djst]]

It's also important to point out that users of Firefox 2.0 WILL still see the content customized for Fx2 as long as they don't actively choose 3.0 or 3.5 in the Actions box (upon which a cookie will be stored to remember their choice). 

I would assume that most people don't click the options here so the content isn't invisible by any means -- only for people who are running 3.0 or 3.5.

Comment 17

[David Tenser [:djst]]

(In reply to comment #16)
> It's also important to point out that users of Firefox 2.0 WILL still see the
> content customized for Fx2 as long as they don't actively choose 3.0 or 3.5 in
> the Actions box (upon which a cookie will be stored to remember their choice). 
> 
> I would assume that most people don't click the options here so the content
> isn't invisible by any means -- only for people who are running 3.0 or 3.5.

I wish my comment above was correct, but unfortunately the fix for this bug had the unintended side-effect of removing Firefox 2.0 support in SHOWFOR altogether. Bug 507771 will fix that regression, upon which things will work the way I described in comment 16.

Apologizes to all localizers affected by this regression. :(