503299 - window.close() from a content tab closes Thunderbird window

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Wladimir Palant]

I am opening a dialog in a Thunderbird tab of type "contentTab". Dialogs call window.close() by default when the accept button is pressed. No issues in Firefox, yet in Thunderbird (Shredder 20090708 build on Windows XP) this closes the entire Thunderbird window. The code preventing this in tabbrowser (and missing in tabmail) seems to be this:

      <handler event="DOMWindowClose" phase="capturing">
        <![CDATA[
          if (!event.isTrusted)
            return;

          const browsers = this.mPanelContainer.childNodes;
          if (browsers.length == 1) {
            // There's only one browser left. If a window is being
            // closed and the window is *not* the window in the
            // browser that's still around, prevent the event's default
            // action to prevent closing a window that's being closed
            // already.
            if (this.getBrowserAtIndex(0).contentWindow != event.target)
              event.preventDefault();

            return;
          }

          var i = 0;
          for (; i < browsers.length; ++i) {
            if (this.getBrowserAtIndex(i).contentWindow == event.target) {
              this.removeTab(this.mTabContainer.childNodes[i]);
              event.preventDefault();

              break;
            }
          }
        ]]>
      </handler>

At the very least, Thunderbird should prevent propagation of this event. However, it can probably also query its tabs whether they "know" the event target - and close the one that does.

Comment 1

[Mark Banner (:standard8)]

Good point, although I'd debate that a tab is not a dialog - a dialog is a special window to display information or get a response. A content tab is just a tab to display content.

However I can port this code across as it sounds like a good idea to have anyway.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

The reason this bug strikes me as important is because it makes it harder for extensions targetted at both Firefox and Thunderbird to Just Work.  It doesn't feel quite important enough to block Tb3, however.

Comment 3

[Mark Banner (:standard8)]

Attachment: Possible fix

I've not tested this yet (apart from running up TB with a tab), but I think this would potentially be enough, though it may need moving to tabmail.xml.

Comment 4

[Wladimir Palant]

Confirmed, this patch fixes the issue for Adblock Plus.

Comment 5

[Mark Banner (:standard8)]

Attachment: The fix

I reworked the previous fix for this a bit. I've now split out setting up the listeners into separate functions and reordered the openTab function - hopefully this makes things a bit clearer especially when it comes to editing.

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/068694714919