503754 - dragging and dropping a tab on the content area reloads the page before detaching the tab

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Dragging and dropping a tab on the content area reloads the page before detaching the tab. The tab should be detached without reloading.

Comment 1

[Alice0775 White]

Regression window:
Fine:
http://hg.mozilla.org/mozilla-central/rev/794b04051344
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090620 Minefield/3.6a1pre ID:20090620042612

Broken:
http://hg.mozilla.org/mozilla-central/rev/a8daae5ef5ce
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090621 Minefield/3.6a1pre ID:20090621041734

Pushlog between the above regression window:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=794b04051344&tochange=a8daae5ef5ce

Candidate bug:
Bug 456106, use new drag and drop api in browser and toolkit



The following workaround patch for chrome://browser/content/browser.jswill fix this isuue.

var contentAreaDNDObserver = {
  onDragOver: function (aEvent)
    {
      var types = aEvent.dataTransfer.types;
      if (types.contains("application/x-moz-file") ||
          types.contains("text/x-moz-url") ||
          types.contains("text/uri-list") ||
          types.contains("text/plain"))
        aEvent.preventDefault();
    },
  onDrop: function (aEvent)
    {
      if (aEvent.getPreventDefault())
        return;

+     var dt = aEvent.dataTransfer;
+     var types = dt.mozTypesAt(0);
+     // When drop tab onto contentarea, do nothing here.
+     if (types[0] == TAB_DROP_TYPE)
+       return;
+
      let [url, name] = browserDragAndDrop.getDragURLFromDataTransfer(aEvent.dataTransfer);

      // valid urls don't contain spaces ' '; if we have a space it

Comment 2

[Dão Gottwald [:dao]]

Thanks Alice.

Comment 3

[Neil Deakin]

Attachment: check types during drop

Comment 4

[Asaf Romano (gone)]

Comment on attachment 389719 [details] [diff] [review]
check types during drop

r=mano

Comment 5

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/3130f487067c