503785 - no logging for incorrect extension proxy files

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Mike Connor [:mconnor]]

https://developer.mozilla.org/en/Setting_up_extension_development_environment#Firefox_extension_proxy_file

If you have an invalid value in the text file, nothing is logged with extensions.logging.enabled set to true.  This seems like something that'd be easy to add and useful to extension developers.

Comment 1

[Dave Townsend [:mossop]]

There are masses of failures around these "proxy" files (who made up that name?) It would be easy to add logging during the first startup, though I suspect right now the presence of the new link causes an EM restart which will throw away anything we log from the error console and kill any text console on windows.

Comment 2

[Dave Townsend [:mossop]]

Fixed by the new extension manager (with bug 575987 to make things even better)

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Basic fix should be in the patch on bug 553169.

Warning: WARN addons.xpi: File pointer /firefox/mozmill-branch/extensions/[e-mail] points to /data/build/etensions/mozmill-crowd/extension which does not exist

Verified with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; en-US; rv:2.0b2pre) Gecko/20100704 Minefield/4.0b2pre

Dave, do we have tests for it?

Comment 4

[Dave Townsend [:mossop]]

We have tests for bad pointer files in test_filepointer.js, they don't verify things are logged but I don't think we should spend time testing that.