504129 - [Regression]:Manage link missing for add-ons listed under "My collections"

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.Log in as [e-mail]
2.Navigate to Collections Homepage
3.Click on "My Collections"
4.Listed addons are-"k's recommendation","tools" and "test123"
5.Notice that the creator is "polka polka.."
6.Navigate to the details page of "k's recommendation"

observed behavior:
Manage collection is missing for collections-"k's recommendation" and "tools" but is available for test123

additional behavior:
the same collections created in production using the same account have manage collection links.

screencast: http://screencast.com/t/9Y1HNREb

Bug 496419 had reported the same behavior but was a diff prob.

Comment 1

[krupa raj[:krupa]]

STR:
1.Login to AMO account
2.Create a new collection.
3.Navigate to the collection detail page

observed behavior:
manage collection link is missing

Comment 2

[Justin Scott [:fligtar]]

I can confirm this.

Comment 3

[krupa raj[:krupa]]

oops-I missed a few  steps in comment# 1-
 4.Click on "Manage collection
 5.Assign a nickname for the collection
 6.Click on the link en-US/firefox/collection/<nickname>

observed behavior:
manage collection link is missing

screencast:http://screencast.com/t/7uVVPDU8

Comment 4

[Wil Clouser [:clouserw]]

I can't reproduce this on my dev copy or preview.amo

Comment 5

[Justin Scott [:fligtar]]

You can't be an admin to reproduce.

Comment 6

[Wil Clouser [:clouserw]]

(In reply to comment #5)
> You can't be an admin to reproduce.

Thanks, we figured that out on IRC.  This is actually caused by bug 496419.  Since thet owner role no longer exists, when someone selects that only they can edit the collection the code deletes all roles that aren't owner (including the managers which is what the owners became).  

It would be easy enough to add the user back in at that point, but that would break when an admin edited a collection for someone.  By saying "only me" on the site and in the code we can't administer collections without deleting their current authors.

Comment 7

[Justin Scott [:fligtar]]

(In reply to comment #6)
> It would be easy enough to add the user back in at that point, but that would
> break when an admin edited a collection for someone.  By saying "only me" on
> the site and in the code we can't administer collections without deleting their
> current authors.

Ok, so can we do that and if the user only has permissions on the collection through being an admin, instead of the "only me" format we just show the dropdown box with all users for editing? I'm not as concerned about the admin interface as I am about fixing the permissions problem by tomorrow.

Comment 8

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

This deletes all users except ourselves -- it works also for admins changing their own collections.

The overall possibility of an admin orphaning a collection persists.

Comment 9

[Fred Wenzel [:wenzel]]

(In reply to comment #7)
> Ok, so can we do that and if the user only has permissions on the collection
> through being an admin, instead of the "only me" format we just show the
> dropdown box with all users for editing?

Sounds good, we should spin this off though.

Comment 10

[Fred Wenzel [:wenzel]]

r29762, thanks.

Comment 11

[krupa raj[:krupa]]

works now