504297 - Message view doesn't always invalidate the tree (possible indication of duplicate messages until scrolled)

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Mark Banner (:standard8)]

Following bug 494811 I noticed one edge case, STR:

1) Select a message
2) Have a new message come in which:
- Changes a single message to a thread (on a non-selected message)
- Moves the single message to the bottom of the view
- Causes the view to scroll

Expected results:

Message thread displayed as collapsed and threaded.

Actual results:

Message thread displayed as collapsed and threaded but has words/description of the thread immediately above it causing it to look like a duplicate.

Comment 1

[David :Bienvenu]

I'll look at this.

Comment 2

[David :Bienvenu]

this is a bit tricky to reproduce - it may depend on whether the thread pane tries to scroll or not when the new header arrives. I've found that selecting a message above the one about to get moved to the bottom helps in reproducing this. It must be that we're not invalidating the right set of rows when doing MoveThread.

Comment 3

[David :Bienvenu]

Attachment: proposed fix

fix off by one error in count of rows to invalidate.

Comment 4

[[e-mail]]

Comment on attachment 391266 [details] [diff] [review]
proposed fix

Good catch!

Comment 5

[David :Bienvenu]

I noticed nsMsgSearchDBView.cpp had the same bug, so I fixed that as well

http://hg.mozilla.org/comm-central/rev/f45fd77e8884