504467 - When filing a bug without a template, bmo's custom "flags" should select "---" rather than the first value

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Daniel Veditz [:dveditz]]

For people who can set the custom blocking1.9.1 flag, the default value on a new bug is "needed" instead of "---".

Comment 1

[Daniel Veditz [:dveditz]]

Sam, if you're wondering why there are so many "needed" bugs to triage this might be why :-)

Comment 2

[Daniel Veditz [:dveditz]]

The Thunderbird bugs in the needed list are certainly victims of this bug. Argh.

Comment 3

[Reed Loden [:reed]]

I can't reproduce this...

Comment 4

[Daniel Veditz [:dveditz]]

STR

1. https://bugzilla.mozilla.org/enter_bug.cgi?product=Core

if you're in the group that can set "needed" then blocking1.9.1 will be "needed" instead of "---"

Comment 5

[Reed Loden [:reed]]

This is just a bug with custom fields in general.

Comment 6

[Reed Loden [:reed]]

<tbody class="expert_fields">
  [% USE Bugzilla %]

  [% FOREACH field = Bugzilla.active_custom_fields %]
    [% NEXT UNLESS field.enter_bug %]
    [% SET value = ${field.name}.defined ? ${field.name} : "" %]
    <tr>
      [% INCLUDE bug/field.html.tmpl
        bug = default, field = field, value = value, editable = 1,
        value_span = 3 %]
    </tr>
  [% END %]
</tbody>


....

This line doesn't make sense to me:
[% SET value = ${field.name}.defined ? ${field.name} : "" %]

???

Why not just set the value to "---", as that's the default, no?

Comment 7

[Frédéric Buclin]

(In reply to comment #6)
> Why not just set the value to "---", as that's the default, no?

No, custom fields have no default values, see bug 351899. But I agree that '---' should be selected by default anyway. Max?

Comment 8

[Max Kanat-Alexander]

This is currently intentional, while we don't have default values, so that people can fake their own default values. The right solution here is to implement bug 351899, and let custom fields actually specify defaults.

Comment 9

[Reed Loden [:reed]]

(In reply to comment #7)
> (In reply to comment #6)
> > Why not just set the value to "---", as that's the default, no?
> 
> No, custom fields have no default values, see bug 351899. But I agree that
> '---' should be selected by default anyway. Max?

'---' is a required field in custom fields, so that's what I'm calling 'default'. I can't change its name at all.

The issue here is that show_bug.cgi works fine when '---' is not the top value in the sort list, but when enter_bug.cgi is used, the top value ('needed') is selected instead. We shouldn't be doing two separate things.

Also, nobody has yet to explain what the point of this line is:
[% SET value = ${field.name}.defined ? ${field.name} : "" %]

Comment 10

[Max Kanat-Alexander]

(In reply to comment #9)
> '---' is a required field in custom fields, so that's what I'm calling
> 'default'. I can't change its name at all.

  That's right, and that's what bug 351899 will fix, so if you want this fixed, you should fix that. I'd rather fix the cause than the symptom.

> The issue here is that show_bug.cgi works fine when '---' is not the top value
> in the sort list,

  That's because it's already been selected.

> Also, nobody has yet to explain what the point of this line is:
> [% SET value = ${field.name}.defined ? ${field.name} : "" %]

  Perhaps some field.names don't have variables associated with them? And if it's not set then TT will continue to use the previous value.

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Yeah, no.

These fields need to default to '---'.  However that's done doesn't matter, but this bug is still valid until going to enter_bug defaults the fields to ---/whatever.  Otherwise drivers are going to be driven crazy.

Comment 12

[Frédéric Buclin]

A trivial way to fix this issue yourself is to set '---' with the lowest sortkey (or said differently: when you add new values, give them a higher sortkey).

Comment 13

[Max Kanat-Alexander]

Okay, this sounds like an issue for the Mozilla developers specific to bmo, so it should go into a different product and component.

To be clear: ANYBODY WHO WANTS THIS FIXED UPSTREAM SHOULD FIX BUG 351899. (This is because many other installations may consider the current behavior to actually be correct.) However, a workaround on bmo for this specific bug should be simple enough.

Comment 14

[Gervase Markham [:gerv]]

All current custom fields on b.m.o. have "---" set as the value with the lowest sortkey. Therefore, this bug as written is not a problem. As Max has said that the more general upstream fix is bug 351899, this bug is a FIXED (in that, someone must have fixed it by changing some sortkeys).

Gerv