504602 - Licenses for Addons are showing up incorrectly

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5
Build Identifier: 5.0.7

The URL should be showing MPL not MIT

Reproducible: Always

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

WTF++

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Attachment: v1

Jeff, 

I think you attempted to create a function I destroyed, but really there's some "index hell" madness going on:

We get the index of the global $licenses array from the DB, and output that.

Comment 3

[Jeff Balogh (:jbalogh)]

Comment on attachment 388988 [details] [diff] [review]
v1

Looks good except for the mad trailing whitespace.

Can you please add `$this->unbindFully();` before $this->findById()?  I just noticed it's pulling in every add-on with the license, which is wasteful.

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

In two revs:

r29885 r29886 

awesomepants:~/Projects/Addons/code % git log                                  
             (504602-license-F)
commit 78f604467c39d733a492b3e6d1d8dcae7e249f79
Author: [e-mail]
<[e-mail]@4eb1ac78-321c-0410-a911-ec516a8615a5>
Date:   Thu Jul 16 21:06:23 2009 +0000

    [bug 504602] Adding unbind fully

    git-svn-id: https://svn.mozilla.org/addons/trunk@29886
4eb1ac78-321c-0410-a911-ec516a8615a5

commit 4ae2d25f034f6634236dfa0fc2e10df024ed24d7
Author: [e-mail]
<[e-mail]@4eb1ac78-321c-0410-a911-ec516a8615a5>
Date:   Thu Jul 16 20:59:25 2009 +0000

    [bug 504602] Fixed some index-hell issues with the global license array so
we can output the correct name of

    git-svn-id: https://svn.mozilla.org/addons/trunk@29885
4eb1ac78-321c-0410-a911-ec516a8615a5

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Doesn't look fixed to me with https://preview.addons.mozilla.org/en-US/firefox/addons/versions/11423; it has "Source Code License MIT/X11 License", but clicking through to https://preview.addons.mozilla.org/en-US/firefox/versions/license/70477 shows MOZILLA PUBLIC LICENSE
                                Version 1.1


According to the page source, preview has r29886, so this should be up-to-date.

Eh, maybe it's cache, or something?

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

I had Jeff verify this.  

If it's a cache issue we have a serious problem.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Comment 5 now works for me; are we still going to push this one-off fix live?