504819 - dashboard v2 fennec support busted

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect)

Description

[Axel Hecht [:Pike]]

Seems like I didn't totally fix fennec, i.e., initial_module for compare-locales isn't set in the new dashboard v2 factory.

Comment 1

[Axel Hecht [:Pike]]

This needs patches in buildbotcustom and compare-locales, and a nitpick in locale-inspector.

Patches coming up.

Comment 2

[Axel Hecht [:Pike]]

Attachment: [checked in] buildbotcustom patch

Attaching two patches for buildbotcustom and compare-locales.

I'm merging L10nConfigParser in both implementations again, after both patches, they're the same code up to the character.

I'm adding two optional entries to l10n.ini:

[general]
source-depth

This overwrites the depth for the SourceTree compare-locales, to get from mobile-browser/locales/en-US to mobile-browser. I didn't want to do too many magic assumptions on directory structures, so this is going in pair with

[compare]
tld

top level dir specifies that the given entry is matching locales/en-US in l10n. This can be specified in addition to dirs= for regular builds setup, and removes the entry if given.

I deprecate single-module-hg as type in l10nbuilds.ini. I map that to type hg in the setup code in l10n.py now. The name still stays live, but is now fed from compare.tld.

The api around dirsIter and directories() changes, it's now returning both the basedir and the en-US module (which might be empty for tlds).

Both patches rely on amended l10n.inis in mobile-browser ala

[general]
depth = ../..
source-depth = ..
all = locales/all-locales

[compare]
dirs = mobile
tld = mobile

[includes]
toolkit = toolkit/locales/l10n.ini

[include_toolkit]
type = hg
mozilla = mozilla-central
repo = http://hg.mozilla.org/
l10n.ini = toolkit/locales/l10n.ini


The patch combo was tested on a local fennec setup with central and 1.9.2 repositories and l10n.inis and x-testing, with commits to l10n and en-US in both toolkit and mobile, triggering the right builds, and given the right compare-locales results.

Comment 3

[Axel Hecht [:Pike]]

Attachment: [checked in] corresponding patch for compare-locales

Corresponding patch for compare-locales. Looks a bit bigger than it is, as I copied over all the comments that are currently in l10n.py.

Forgot to mention that I tested this with langpacker.py, too. That needs patching to pick up these changes, too.

Once reviewed, I should push an updated release of compare-locales to pypi.

Given the set of builds that releng does, I don't think that we need to move the compare-locales releng tag.

Comment 4

[Chris Cooper [:coop] (he/him)]

Comment on attachment 397862 [details] [diff] [review]
[checked in] corresponding patch for compare-locales

Yay for comments and doc strings!

Comment 5

[Axel Hecht [:Pike]]

Attachment: [checked in] add tld and depth to fennec's l10n.ini's

Coop, do you have a cycle to review the l10n.ini patch, too?

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 400052 [details] [diff] [review]
[checked in] add tld and depth to fennec's l10n.ini's

http://hg.mozilla.org/mobile-browser/rev/a86b410cb8f9, fennec part landed.

Comment 7

[Chris Cooper [:coop] (he/him)]

Comment on attachment 397860 [details] [diff] [review]
[checked in] buildbotcustom patch

http://hg.mozilla.org/build/buildbotcustom/rev/56a77756b028

Comment 8

[Chris Cooper [:coop] (he/him)]

Comment on attachment 397862 [details] [diff] [review]
[checked in] corresponding patch for compare-locales

http://hg.mozilla.org/build/compare-locales/rev/35b7774af82e

Comment 9

[Chris Cooper [:coop] (he/him)]

I just reconfig-ed both production masters with the buildbotcustom change.

Comment 10

[Axel Hecht [:Pike]]

I'm pretty sure this is fixed, but I still need to see more data on stage. Blocking public stage in bug 522293, for sure.

Comment 11

[Axel Hecht [:Pike]]

This is FIXED now. Had to be a little bit tricked by bug 527019, which made me look at wrong versions to be compared, too. That one independent of fennec, though.