560856 - [compare-locales] local compare-locales busted for fennec

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect, P1)

Description

[Axel Hecht [:Pike]]

AFAICT, I busted local compare-locales runs for fennec in bug 504819.

This is showing now as l10n-merge isn't working.

The culprit is that if we find tld, we unconditionally remove it from dirs in L10nConfigParser.onLoadConfig, but only iterate over it cleverly in the SourceTreeConfigParser.dirsIter.

Effectively, we're not running compare-locales on the mobile dir at all.

Bad. P1.

PS: Also a bad sign that for about half a year, nobody noticed that l10n merge on fennec was apparently just a lie.

Comment 1

[Axel Hecht [:Pike]]

OK, this wasn't broken in production since September, because we never actually bumped the RELEASE_AUTOMATION tag to use that.

It was broken in the source though. Not sure if I had a broken release on pypi.

I confirmed that it was actually http://hg.mozilla.org/build/compare-locales/rev/35b7774af82e that regressed this locally, aka bug 504819.

Comment 2

[Axel Hecht [:Pike]]

Attachment: move the generation of the base path tuple into method and overload

coop, can you review this?

The basic gist of it is this:

directories() returns a list of l10n module and a tuple of path segments, where the latter is used to construct the reference code in en-US.

For regular local builds, that should return (basepath, 'mobile') and for src-tree work it'd just be (basepath). src-tree here means that you have your sources on disk as on hg, and not mobile-browser as mobile inside central or 1.9.2.

I tested this with both compare-locales, and langpacker (which uses plain src), with and without merge.

I'd take an r+ to include bumping the RELEASE_AUTOMATION tag to a revision with this patch, i.e., including the changesets http://hg.mozilla.org/build/compare-locales/graph/22?revcount=4. None of them are functional, though, just for reference that we don't make the "let's just bump" mistake again.

Comment 3

[Chris Cooper [:coop] (he/him)]

Comment on attachment 440586 [details] [diff] [review]
move the generation of the base path tuple into method and overload

(In reply to comment #2) 
> I'd take an r+ to include bumping the RELEASE_AUTOMATION tag to a revision with
> this patch, i.e., including the changesets
> http://hg.mozilla.org/build/compare-locales/graph/22?revcount=4. None of them
> are functional, though, just for reference that we don't make the "let's just
> bump" mistake again.

Patch looks fine. Who's going to bump the tag?

Comment 4

[Axel Hecht [:Pike]]

Fixed, http://hg.mozilla.org/build/compare-locales/rev/bfb8fb7970df.

Sorry for the trouble.

RELEASE_AUTOMATION tag moved, too, http://hg.mozilla.org/build/compare-locales/rev/fdb241a03df5, and released 0.8.2 to pypi.