505558 - About dialog too narrow for localized TB3.0b3 builds

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Cédric Corazza]

Attachment: About > Credits snapshot in French

In the French locale, and I guess in most of the other locales, the About dialog is "broken" because of the addition of the new button.
As suggested by Mark "standard8" Banner, this could be gathered in a single button and he will warn the UI team about this.
I didn't test this on the other 2 platforms, but it should be the same.

Comment 1

[Cédric Corazza]

Attachment: The second snapshot

In fact, in this one, the "OK" button is also cut, but my snapshot utility didn't catch it (Gnome screencapture)...

Comment 2

[Mark Banner (:standard8)]

Attachment: Proposed fix

Aiming to get this one in before string freeze. Magnus and Phil have various string patches, so pushing to David.

Basic idea is to combine the credits button and the about menu button into one. This should give localisers the width back. I'll attach a couple of screen shots in a moment.

Whilst I'm not 100% happy with the different resultant actions from clicking on the menu items, I think it is probably the best option we have for now.

Comment 3

[Mark Banner (:standard8)]

Attachment: Before

Comment 4

[Mark Banner (:standard8)]

Attachment: After

Comment 5

[Rimas Kudelis [use needinfo to ping]]

What is the difference between Credits and Contributors BTW? From the users POV, both just show a bunch of names.

Comment 6

[Rimas Kudelis [use needinfo to ping]]

Also, note how the "Credits" button says "Contributeurs" in French builds.

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #5)
> What is the difference between Credits and Contributors BTW? From the users
> POV, both just show a bunch of names.

Credits are people we explicitly want to credit. They are folks who have made a significant contribution to the shipping of Thunderbird 3.

Contributors are the people that "made a significant investment of time, with useful results, into Mozilla project-governed activities". Hence this list is a lot wider than the list of people specifically helping Thunderbird 3.

Would a couple of localisation notes help to explain it here?

Comment 8

[Rimas Kudelis [use needinfo to ping]]

Maybe... Two things though:
1) Fx acts differently here, and I like consistency. :)
2) Is there a bug asking for l12y of about:credits?

Comment 9

[Mark Banner (:standard8)]

(In reply to comment #8)
> Maybe... Two things though:
> 1) Fx acts differently here, and I like consistency. :)

It isn't actually that inconsistent. You click on credits you go to the Firefox specific credits list, then you can click on a "Contributors" link that gives you the full Mozilla list.

The patch would just make Thunderbird have the two links in the one menu, rather than having to do two clicks to get to "Contributors".

> 2) Is there a bug asking for l12y of about:credits?

No idea. At the moment it is a web page hosted on mozilla.org.

Comment 10

[Rimas Kudelis [use needinfo to ping]]

Attachment: lt screenshot on Windows

(In reply to comment #9)
> (In reply to comment #8)
> > Maybe... Two things though:
> > 1) Fx acts differently here, and I like consistency. :)
> 
> It isn't actually that inconsistent. You click on credits you go to the Firefox
> specific credits list, then you can click on a "Contributors" link that gives
> you the full Mozilla list.
> 
> The patch would just make Thunderbird have the two links in the one menu,
> rather than having to do two clicks to get to "Contributors".

That's the inconsistency I was talking about. :)

> > 2) Is there a bug asking for l12y of about:credits?
> 
> No idea. At the moment it is a web page hosted on mozilla.org.

I'll ask Axel about that.

One more thing: At least on Windows, the OK button should be aligned right I think. It's currently not (see my screenshot).

Comment 11

[Wim]

Another thing: why is the name Mark Lanett flashing/blinking on the contributors page?

Comment 12

[Rimas Kudelis [use needinfo to ping]]

(In reply to comment #11)
> Another thing: why is the name Mark Lanett flashing/blinking on the
> contributors page?

I was also wondering. Apparently, this guy implemented the <blink> tag. :)

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 403232 [details] [diff] [review]
Proposed fix

Approving for checking - low risk patch that improves the situation for localisers.

Comment 14

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/6a8202d79d25