Closed Bug 505558 Opened 11 years ago Closed 10 years ago

About dialog too narrow for localized TB3.0b3 builds

Categories

(Thunderbird :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: cedric.corazza, Assigned: standard8)

Details

(Keywords: l12y, Whiteboard: [has l10n impact])

Attachments

(6 files)

In the French locale, and I guess in most of the other locales, the About dialog is "broken" because of the addition of the new button.
As suggested by Mark "standard8" Banner, this could be gathered in a single button and he will warn the UI team about this.
I didn't test this on the other 2 platforms, but it should be the same.
Attached image The second snapshot
In fact, in this one, the "OK" button is also cut, but my snapshot utility didn't catch it (Gnome screencapture)...
Summary: About dialog "broken" for localized TB3.0b3 builds → About dialog too narrow for localized TB3.0b3 builds
Assignee: nobody → bugzilla
Flags: wanted-thunderbird3+
Whiteboard: [has l10n impact]
Attached patch Proposed fixSplinter Review
Aiming to get this one in before string freeze. Magnus and Phil have various string patches, so pushing to David.

Basic idea is to combine the credits button and the about menu button into one. This should give localisers the width back. I'll attach a couple of screen shots in a moment.

Whilst I'm not 100% happy with the different resultant actions from clicking on the menu items, I think it is probably the best option we have for now.
Attachment #403232 - Flags: ui-review?(clarkbw)
Attachment #403232 - Flags: review?(bienvenu)
Attached image Before
Attached image After
Target Milestone: --- → Thunderbird 3.0rc1
Attachment #403234 - Attachment is patch: false
Attachment #403234 - Attachment mime type: text/plain → image/png
Attachment #403232 - Flags: review?(bienvenu) → review+
What is the difference between Credits and Contributors BTW? From the users POV, both just show a bunch of names.
Also, note how the "Credits" button says "Contributeurs" in French builds.
(In reply to comment #5)
> What is the difference between Credits and Contributors BTW? From the users
> POV, both just show a bunch of names.

Credits are people we explicitly want to credit. They are folks who have made a significant contribution to the shipping of Thunderbird 3.

Contributors are the people that "made a significant investment of time, with useful results, into Mozilla project-governed activities". Hence this list is a lot wider than the list of people specifically helping Thunderbird 3.

Would a couple of localisation notes help to explain it here?
Maybe... Two things though:
1) Fx acts differently here, and I like consistency. :)
2) Is there a bug asking for l12y of about:credits?
(In reply to comment #8)
> Maybe... Two things though:
> 1) Fx acts differently here, and I like consistency. :)

It isn't actually that inconsistent. You click on credits you go to the Firefox specific credits list, then you can click on a "Contributors" link that gives you the full Mozilla list.

The patch would just make Thunderbird have the two links in the one menu, rather than having to do two clicks to get to "Contributors".

> 2) Is there a bug asking for l12y of about:credits?

No idea. At the moment it is a web page hosted on mozilla.org.
(In reply to comment #9)
> (In reply to comment #8)
> > Maybe... Two things though:
> > 1) Fx acts differently here, and I like consistency. :)
> 
> It isn't actually that inconsistent. You click on credits you go to the Firefox
> specific credits list, then you can click on a "Contributors" link that gives
> you the full Mozilla list.
> 
> The patch would just make Thunderbird have the two links in the one menu,
> rather than having to do two clicks to get to "Contributors".

That's the inconsistency I was talking about. :)

> > 2) Is there a bug asking for l12y of about:credits?
> 
> No idea. At the moment it is a web page hosted on mozilla.org.

I'll ask Axel about that.

One more thing: At least on Windows, the OK button should be aligned right I think. It's currently not (see my screenshot).
Another thing: why is the name Mark Lanett flashing/blinking on the contributors page?
(In reply to comment #11)
> Another thing: why is the name Mark Lanett flashing/blinking on the
> contributors page?

I was also wondering. Apparently, this guy implemented the <blink> tag. :)
Attachment #403232 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 403232 [details] [diff] [review]
Proposed fix

Approving for checking - low risk patch that improves the situation for localisers.
Attachment #403232 - Flags: approval-thunderbird3+
Checked in: http://hg.mozilla.org/comm-central/rev/6a8202d79d25
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.