Closed
Bug 505594
Opened 16 years ago
Closed 16 years ago
[HTML5] Actually place java translator files under Mercurial revision control
Categories
(Core :: DOM: HTML Parser, enhancement)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: mozilla+ben, Assigned: mozilla+ben)
References
Details
Attachments
(1 file)
154.61 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Currently (as of bug 499141), the Java source files implementing the Java-to-C++ translator are checked into mozilla-central in the loose sense that Makefile targets exist in parser/html/java to pull the files in from Henri's validator.nu repo, build the translator, and perform the translation.
Under this model, occasional bugfixes can be posted to bugzilla.validator.nu, and if Henri accepts them, 'make sync' and 'make translate' can eventually make use of the updated files.
Since the rate of changes to the translator is increasing, I think it will be easiest for Henri and everyone else if we maintain a copy of the translator Java sources in mozilla-central/parser/html/java/translator/src. Doing so will preserve a record of those changes, so that Henri can easily review them and decide what he wants to backport.
When/if Henri moves from Subversion to Mercurial, this synchronization process should become easier, as we'll be able to include the translator as a subrepository.
Assignee | ||
Comment 1•16 years ago
|
||
The only outward change this patch introduces is that 'make sync' is no longer necessary for the translator. Before landing, make sure 524 is still the latest revision of the validator.nu htmlparser repo.
Attachment #389822 -
Flags: superreview?(jst)
Attachment #389822 -
Flags: review?(jst)
Updated•16 years ago
|
Attachment #389822 -
Flags: superreview?(jst)
Attachment #389822 -
Flags: superreview+
Attachment #389822 -
Flags: review?(jst)
Attachment #389822 -
Flags: review+
Assignee | ||
Comment 2•16 years ago
|
||
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/acbf6f61ca40
No regression risk, as this patch introduces no build- or run-time behavioral changes.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•