[HTML5] Check in the Java to C++ translator

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: hsivonen, Unassigned)

Tracking

(Blocks 1 bug)

Other Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

It would be convenient to have the Java to C++ translator that is used for generating parts of the HTML5 parser in the tree so that anyone who needs to run it doesn't need to obtain a suitable revision separately.

Checking it in has been OKed by licensing at mozilla.org.
Assignee: hsivonen → nobody
Is there a project name for this? For the moment I think we want an entirely separate repository such as hg.mozilla.org/html5parser.

If you like we can look at importing the history from subversion... the convert tool should do this without problems.
(In reply to comment #1)
> If you like we can look at importing the history from subversion... the convert
> tool should do this without problems.

Indeed it does:
http://hg.mozilla.org/users/bnewman_mozilla.com/html5parser/
When/if Henri switches to Mercurial, we can simply update parser/html/java/htmlparser/Makefile.

Also updated the license blocks to list me as a contributor instead of the initial developer.
Attachment #388568 - Flags: superreview?(jst)
Attachment #388568 - Flags: review?(jst)
Attachment #388568 - Flags: superreview?(jst)
Attachment #388568 - Flags: superreview+
Attachment #388568 - Flags: review?(jst)
Attachment #388568 - Flags: review+
Comment on attachment 388568 [details] [diff] [review]
make targets to update java sources and perform translation

- In parser/html/javasrc:

@@ -0,0 +1,1 @@
+java/htmlparser/src
\ No newline at end of file

Add a newline? :)

Let's get this in to start with, we'll update this once the HTML5 Java source is moved to a new home and tweak as needed when needed.

r+sr=jst
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/3c25f8166818
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 388568 [details] [diff] [review]
make targets to update java sources and perform translation

>diff --git a/.hgignore b/.hgignore

>+\.class$

This seems like a bad idea in general, given that we have two checked in *.class files (below).  Maybe it could be restricted to certain directories?

dom/tests/mochitest/dom-level2-html/files/applets/org/w3c/domts/DOMTSApplet.class
dom/tests/mochitest/dom-level2-html/files/applet2.class
Based on a brief experiment just now, it appears that .hgignore patterns don't have any bearing on files that've been 'hg add'-ed, meaning that any existing .class files (like these two) are safe.  However, I'm more than happy to restrict the pattern to exclude just the files I've knowingly introduced.
Attachment #388769 - Flags: superreview?(dbaron)
Attachment #388769 - Flags: review?(dbaron)
Attachment #388769 - Flags: superreview?(dbaron)
Attachment #388769 - Flags: review?(dbaron)
Attachment #388769 - Flags: review+
This all started when I wanted to change 'make sync' so that it didn't clobber local files.  I noticed that I was repeating the same changes in two or three different Makefiles, so I moved the common bits into proper shell scripts.
Attachment #388802 - Flags: superreview?(jst)
Attachment #388802 - Flags: review?(jst)
Attachment #388769 - Flags: superreview?(jst)
Please file a new bug for followups, this bug is fixed! :)
Attachment #388769 - Attachment is obsolete: true
Attachment #388769 - Flags: superreview?(jst)
Comment on attachment 388802 [details] [diff] [review]
refactor repetitive makefile shell commands into external scripts

Created followup bug 504444.
Attachment #388802 - Attachment is obsolete: true
Attachment #388802 - Flags: superreview?(jst)
Attachment #388802 - Flags: review?(jst)
You need to log in before you can comment on or make changes to this bug.