nsWifiMonitor::DoScan seems to leak ndis_handle in all failure cases

RESOLVED FIXED

Status

()

--
minor
RESOLVED FIXED
9 years ago
4 months ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

(Blocks: 1 bug, {coverity, memory-leak})

Trunk
ARM
Windows CE
coverity, memory-leak
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

1.12 KB, patch
timeless
: review+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
338 nsWifiMonitor::DoScan()
343 HANDLE ndis_handle;
344 GETADAPTERSINFO pGetAdaptersInfo;
345 nsresult rc = SetupWince(ndis_handle, pGetAdaptersInfo); 

384 BYTE *buffer = (BYTE*)malloc(oid_buffer_size_);
385 if (buffer == NULL)
it leaks here:
386 return NS_ERROR_OUT_OF_MEMORY; 
and here:
496         return NS_ERROR_OUT_OF_MEMORY;
(Assignee)

Comment 1

9 years ago
Created attachment 390133 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #390133 - Flags: review?(doug.turner)

Comment 2

9 years ago
Comment on attachment 390133 [details] [diff] [review]
patch

kill this line all together:

- 	
+ 
 

What about the wlan_library library too?
Attachment #390133 - Flags: review?(doug.turner) → review-
(Assignee)

Comment 3

9 years ago
Created attachment 390316 [details] [diff] [review]
reviewed

that's bug 505726
Attachment #390133 - Attachment is obsolete: true
Attachment #390316 - Flags: review+
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/mozilla-central/rev/23c898a183eb
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Blocks: 1230156
You need to log in before you can comment on or make changes to this bug.