Closed
Bug 505725
Opened 16 years ago
Closed 16 years ago
nsWifiMonitor::DoScan seems to leak ndis_handle in all failure cases
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, memory-leak)
Attachments
(1 file, 1 obsolete file)
|
1.12 KB,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
338 nsWifiMonitor::DoScan()
343 HANDLE ndis_handle;
344 GETADAPTERSINFO pGetAdaptersInfo;
345 nsresult rc = SetupWince(ndis_handle, pGetAdaptersInfo);
384 BYTE *buffer = (BYTE*)malloc(oid_buffer_size_);
385 if (buffer == NULL)
it leaks here:
386 return NS_ERROR_OUT_OF_MEMORY;
and here:
496 return NS_ERROR_OUT_OF_MEMORY;
|
||
Comment 2•16 years ago
|
||
Comment on attachment 390133 [details] [diff] [review]
patch
kill this line all together:
-
+
What about the wlan_library library too?
Attachment #390133 -
Flags: review?(doug.turner) → review-
that's bug 505726
Attachment #390133 -
Attachment is obsolete: true
Attachment #390316 -
Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•