Closed Bug 506041 Opened 10 years ago Closed 9 years ago

Part 2: Correct misspellings in source code

Categories

(Core :: General, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: mkohler, Assigned: mkohler)

References

Details

Attachments

(8 files, 35 obsolete files)

5.52 KB, patch
timeless
: review+
Details | Diff | Splinter Review
46.18 KB, patch
nelson
: review+
Details | Diff | Splinter Review
13.39 KB, patch
nelson
: review-
Details | Diff | Splinter Review
4.37 KB, patch
timeless
: review+
Details | Diff | Splinter Review
2.08 KB, patch
nelson
: review+
Details | Diff | Splinter Review
183.54 KB, patch
mkohler
: review+
Details | Diff | Splinter Review
4.78 KB, patch
mkohler
: review+
Details | Diff | Splinter Review
10.84 KB, patch
mkohler
: review+
Details | Diff | Splinter Review
Since bug 106386 gets bigger and bigger I decided to open a new bug for newer misspellings.

http://mxr.mozilla.org/mozilla-central/search?string=differnet
No longer depends on: 106386
Alias: spelling
Status: NEW → ASSIGNED
http://mxr.mozilla.org/mozilla1.9.1/search?string=ouput

Note a patch fixing this is not just comments-only - nsIAccessibleProvider.idl requires a change in a property name, so the UUID must be updated at the same time.
This is probably where you say, "I'm sorry I asked!"

I went through the list of 100 most misspelled words to see what I could come up with.  (I apologize if there are duplicates from the other comments.)

http://mxr.mozilla.org/mozilla-central/search?string=threshhold&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=supercede&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=seperate&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=+refrence&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=refered&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=recieve&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=priviledge&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=preceed&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=occurrance&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=noticable&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=judgement&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=independant&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=existance&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

http://mxr.mozilla.org/mozilla-central/search?string=changable&find=%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
57    * Initialize the reader with the edia stream.

s/edia/media/

http://mxr.mozilla.org/mozilla-central/source/content/media/ogg/nsChannelReader.h#57
Depends on: 260911
Depends on: 560061
I will create a first patch tomorrow.
Attached patch accessible - misspellings (obsolete) — Splinter Review
This and the following patches are splitted up per component (or a few components together). These patches change the following misspellings:

differnet -> different
loose -> lose
ouput -> output
implment -> implement
occured -> occurred
mainted -> maintained
teh -> the
untill -> until
seperated -> separated
refrence -> reference
refered -> referred
prefered -> preferred
priviledge -> privilege
preceeding -> preceding
preceeds -> preceds
occurrance -> occurrence
noticable -> noticeable
independant -> independent
changable -> changeable
existance -> existence
existant -> existent
elipse -> ellipse
bahaviour -> behaviour
supress -> suppress
supercede -> supersede
recieve -> receive
Attachment #441369 - Flags: review?(timeless)
Attached patch browser - misspellings (obsolete) — Splinter Review
Attachment #441370 - Flags: review?(timeless)
Attachment #441371 - Flags: review?(timeless)
Attached patch content - misspellings (obsolete) — Splinter Review
Attachment #441372 - Flags: review?(timeless)
Attached patch db / dom - misspellings (obsolete) — Splinter Review
Attachment #441373 - Flags: review?(timeless)
Attached patch intl / ipc - misspellings (obsolete) — Splinter Review
Attachment #441374 - Flags: review?(timeless)
Attached patch js - misspellings (obsolete) — Splinter Review
Attachment #441375 - Flags: review?(timeless)
Attached patch layout/media - misspellings (obsolete) — Splinter Review
Attachment #441376 - Flags: review?(timeless)
Attached patch modules/netwerk - misspellings (obsolete) — Splinter Review
Attachment #441377 - Flags: review?(timeless)
Attachment #441369 - Flags: review?(timeless) → review+
Attachment #441370 - Flags: review?(timeless) → review+
Attached patch nsprpub/parser - misspellings (obsolete) — Splinter Review
Attachment #441378 - Flags: review?(timeless)
Attached patch security - misspellings (obsolete) — Splinter Review
Attachment #441379 - Flags: review?(timeless)
Attached patch testing/toolkit - misspellings (obsolete) — Splinter Review
Attachment #441382 - Flags: review?(timeless)
Attachment #441383 - Flags: review?(timeless)
Attachment #441371 - Flags: review?(timeless) → review+
(In reply to comment #20)
> supercede -> supersede

What's wrong with supercede?
(In reply to comment #33)
> (In reply to comment #20)
> > supercede -> supersede
> 
> What's wrong with supercede?

Meh, ignore that.  I suppose it's technically an error, and it's certainly just bikeshedding :-)
Attachment #441372 - Flags: review?(timeless) → review+
Comment on attachment 441373 [details] [diff] [review]
db / dom - misspellings

please exclude sqlite, they have their own bug tracker. i've been meaning to send them a patch for spelling stuff (based on work i did on Symbian).

+          this.assertNull(transport.getHeader('X-Inexistent'));

this should be nonexistent

(the word shouldn't be hyphentated.)

otherwise everything else is ok.
Attachment #441373 - Flags: review?(timeless) → review-
Comment on attachment 441374 [details] [diff] [review]
intl / ipc - misspellings

chromium has an upstream, please send this patch to them.
Attachment #441374 - Flags: review?(timeless) → review-
Comment on attachment 441375 [details] [diff] [review]
js - misspellings

drop js/src/ctypes/libffi/ChangeLog

libffi should have an upstream, so a patch should be sent to it.

otherwise this looks fine.
Attachment #441375 - Flags: review?(timeless) → review-
Comment on attachment 441376 [details] [diff] [review]
layout/media - misspellings

libfishsound/liboggz/libtheora/libvorbis have upstreams, please file bugs to them - i think it's all the same upstream.
Attachment #441376 - Flags: review?(timeless) → review-
Comment on attachment 441377 [details] [diff] [review]
modules/netwerk - misspellings

freetype should have an upstream (although it's possibly defunct)
Attachment #441377 - Flags: review?(timeless) → review-
Comment on attachment 441378 [details] [diff] [review]
nsprpub/parser - misspellings

split nspr from parser, nspr requires a distinct committer.

occuring(sp)
Attachment #441378 - Flags: review?(timeless) → review-
Attachment #441379 - Flags: review?(timeless) → review?(nelson)
Comment on attachment 441379 [details] [diff] [review]
security - misspellings

this looks good to me, but nelson has to do the commit (he can probably do the nspr commit too).
Comment on attachment 441382 [details] [diff] [review]
testing/toolkit - misspellings

google-breakpad has an upstream. please file it and then exclude. otherwise it looks good to me.
Attachment #441382 - Flags: review?(timeless) → review-
Attachment #441383 - Flags: review?(timeless) → review+
The above "security" patch includes patches to files in two Mozilla modules,
which are: PSM and NSS.  I have separated out the PSM part into this file.
Timeless, I'll let you review and/or commit this, if you wish.

I will convert the NSS part of the above security patch to a CVS diff and 
attach it to this bug, and then review it.
Attachment #441401 - Flags: review?(timeless)
This is the NSS part of the above (now obsoleted) "security" patch.
I will review this.
Attachment #441379 - Attachment is obsolete: true
Attachment #441404 - Flags: review?(nelson)
Attachment #441379 - Flags: review?(nelson)
Attachment #441404 - Attachment description: NSS part of the above "security" patch, coverted to CVS diff → NSS part of the above "security" patch, converted to CVS diff
Comment on attachment 441404 [details] [diff] [review]
NSS part of the above "security" patch, converted to CVS diff (partially committed)

This patch is not "atomic".  It need not be accepted or rejected 
as a whole.  Parts of it can be accepted, and other parts rejected.
That's what I'm going to do.  I have accepted and committed parts 
of this patch (as noted below) and so will mark this r+.  But I will 
soon attach another patch which is the remnant of this patch that 
I did not accept, and I will explain why.

Bug 506041: Correct misspellings in source code comments 
Patch contributed by Michael Kohler <michaelkohler@live.com>, r=nelson

coreconf/jniregen.pl;                               new: 1.5;  previous: 1.4
coreconf/outofdate.pl;                              new: 1.3;  previous: 1.2
coreconf/rules.mk;                                  new: 1.83; previous: 1.82
nss/cmd/bltest/blapitest.c;                         new: 1.59; previous: 1.58
nss/cmd/crlutil/crlutil.c;                          new: 1.33; previous: 1.32
nss/cmd/lib/SECerrs.h;                              new: 1.20; previous: 1.19
nss/cmd/pk11mode/pk11mode.c;                        new: 1.28; previous: 1.27
nss/lib/certdb/alg1485.c;                           new: 1.40; previous: 1.39
nss/lib/ckfw/capi/crsa.c;                           new: 1.4;  previous: 1.3
nss/lib/ckfw/nssmkey/mobject.c;                     new: 1.5;  previous: 1.4
nss/lib/crmf/crmf.h;                                new: 1.4;  previous: 1.3
nss/lib/libpkix/pkix_pl_nss/system/pkix_pl_mutex.c; new: 1.7;  previous: 1.6
nss/lib/libpkix/pkix/top/pkix_build.c               new: 1.58; previous: 1.57
nss/lib/nss/nss.h;                                  new: 1.80; previous: 1.79
nss/lib/pk11wrap/pk11merge.c;                       new: 1.7;  previous: 1.6
nss/lib/pk11wrap/pk11nobj.c;                        new: 1.12; previous: 1.11
nss/lib/pk11wrap/pk11pub.h;                         new: 1.32; previous: 1.31
nss/lib/pk11wrap/pk11util.c;                        new: 1.58; previous: 1.57
nss/lib/pkcs12/p12d.c;                              new: 1.46; previous: 1.45
nss/lib/pkcs12/p12dec.c;                            new: 1.7;  previous: 1.6
nss/lib/pki/nsspkit.h;                              new: 1.7;  previous: 1.6
nss/lib/smime/cms.h;                                new: 1.23; previous: 1.22
nss/lib/smime/cmssiginfo.c;                         new: 1.32; previous: 1.31
nss/lib/ssl/sslcon.c;                               new: 1.40; previous: 1.39
nss/lib/ssl/sslgathr.c;                             new: 1.12; previous: 1.11
nss/lib/ssl/sslsock.c;                              new: 1.67; previous: 1.66
nss/lib/util/portreg.c;                             new: 1.7;  previous: 1.6
nss/lib/util/secdig.h;                              new: 1.9;  previous: 1.8
nss/lib/zlib/deflate.h;                             new: 1.6;  previous: 1.5
nss/tests/cert/cert.sh;                             new: 1.57; previous: 1.56
nss/tests/dbtests/dbtests.sh;                       new: 1.23; previous: 1.22
nss/tests/pkcs11/netscape/trivial/trivial.c;        new: 1.5;  previous: 1.4
Attachment #441404 - Attachment description: NSS part of the above "security" patch, converted to CVS diff → NSS part of the above "security" patch, converted to CVS diff (partially committed)
Attachment #441404 - Flags: review?(nelson) → review+
This patch serves to document the part of the above NSS patch that cannot be
checked into the NSS trunk in its present form.  There are three different 
reasons:

1) We cannot change the names of members of structures declared in public 
header files once those have been released.  So, we cannot rename the members
from "priviledge" to "privilege", much as we might wish.  What we CAN do is 
add a #define to add a synonym with the correct spelling.  

2) Some of the files patched here are part of a body of code that has been 
certified by the US government as cryptographically sound, and *ANY* changes
to those files (even to comments) invalidate that certification, necessitating
a new certification.  So, we make those changes on a branch which we hold 
until the next time we plan to go through a certification.  We JUST finished
a certification earlier this month, so it will be some time before we do 
another.  This applies to the files in "softoken".

3. The sqlite3 file is a file we take from an upstream source.  We strongly 
prefer to make only the absolutely necessary changes to the source as received from that upstream, and keep all changes out unless they are absolutely necessary for the correct execution of the code, which clearly comments do 
not affect.  I'd suggest you send your corrections for the sqlite3 code to 
the upstream source.  If they're part of the next release we take from that
upstream source, then we'll get those changes that way.

I suggest you do as follows:
1) submit a new patch attached to this bug, to address the "priviledge" issue with a synonym, and ask me to review it.
2) File a new bug against product NSS about the proposed changes for the 
files in softoken.  We'll get that into the review process for that code.
3) send your sqlite3 changes to the sqlite3 upstream, whereever that is.
Attachment #441408 - Flags: review-
This is the alternative I proposed above to fix the misspelled priviledge 
members without actually changing the names of the members in the struct.

Michael, does this satisfy you?
If so, Timeless, please review & I'll give credit for this patch to Michael.
Attachment #441423 - Flags: review?(timeless)
Attachment #441401 - Flags: review?(timeless) → review+
Comment on attachment 441423 [details] [diff] [review]
NSS patch for the alternative priviledge->privilege fix (committed)

you should probably add a comment to keythi.h explaining the defines.
Attachment #441423 - Flags: review?(timeless) → review+
Nelson, sure it satisfies me, well done!  And please feel free to take credits for yourself.

I will update the other patches in a few hours.
Attached patch dom v2 (without db now) (obsolete) — Splinter Review
Attachment #441373 - Attachment is obsolete: true
Attachment #441571 - Flags: review?(timeless)
Attachment #441571 - Attachment description: dom v2 (without ipc now) → dom v2 (without db now)
Attached patch intl v2 (without ipc now) (obsolete) — Splinter Review
Attachment #441374 - Attachment is obsolete: true
Attachment #441572 - Flags: review?(timeless)
Attached patch js v2 (obsolete) — Splinter Review
Attachment #441375 - Attachment is obsolete: true
Attachment #441574 - Flags: review?(timeless)
Attached patch layout/media v2 (obsolete) — Splinter Review
Attachment #441376 - Attachment is obsolete: true
Attachment #441576 - Flags: review?(timeless)
Attached patch parser v2 (without nsprpub) (obsolete) — Splinter Review
Attachment #441378 - Attachment is obsolete: true
Attachment #441578 - Flags: review?(timeless)
Attached patch nsprpub v2 (obsolete) — Splinter Review
Attachment #441579 - Flags: review?(timeless)
Attached patch parser v2.1 (obsolete) — Splinter Review
uploaded too early, I'm sorry for bugspam.
Attachment #441578 - Attachment is obsolete: true
Attachment #441582 - Flags: review?(timeless)
Attachment #441578 - Flags: review?(timeless)
Attached patch modules/netwerk v2 (obsolete) — Splinter Review
Attachment #441377 - Attachment is obsolete: true
Attachment #441584 - Flags: review?(timeless)
Attached patch testing/toolkit v2 (obsolete) — Splinter Review
Attachment #441382 - Attachment is obsolete: true
Attachment #441585 - Flags: review?(timeless)
Attached patch other-licenses - misspellings (obsolete) — Splinter Review
Found another patch which you've not yet seen. Did I upload every updated patch of the r- patches? I think I didn't forget something.
Attachment #441588 - Flags: review?(timeless)
Comment on attachment 441571 [details] [diff] [review]
dom v2 (without db now)

didn't we agree on nonexistent instead of non-existent? :(

X-nonexistent
should be
X-Nonexistent
to match the style.
Attachment #441571 - Flags: review?(timeless) → review-
Attachment #441572 - Flags: review?(timeless) → review+
Comment on attachment 441574 [details] [diff] [review]
js v2

inexistent => nonexistent
non-existent => nonexistent
Attachment #441574 - Flags: review?(timeless) → review-
Comment on attachment 441576 [details] [diff] [review]
layout/media v2

:(, exclude libogg

Non-existent => Nonexistent
Attachment #441576 - Flags: review?(timeless) → review-
Comment on attachment 441579 [details] [diff] [review]
nsprpub v2

nonexistence

nelson: can you commit this?
Attachment #441579 - Flags: review?(timeless)
Attachment #441579 - Flags: review?(nelson)
Attachment #441579 - Flags: review+
Attachment #441582 - Flags: review?(timeless) → review+
Comment on attachment 441584 [details] [diff] [review]
modules/netwerk v2

sorry

libimg/png is a third party library http://sourceforge.net/tracker/?atid=105624&group_id=5624&func=browse

modules/zlib is http://www.gzip.org/zlib/zlib_faq.html#faq08

everything else is fine.
Attachment #441584 - Flags: review?(timeless) → review-
Attachment #441585 - Flags: review?(timeless) → review+
Comment on attachment 441588 [details] [diff] [review]
other-licenses - misspellings

http://sourceforge.net/tracker/?atid=373085&group_id=22049&func=browse
Attachment #441588 - Flags: review?(timeless) → review-
Comment on attachment 441579 [details] [diff] [review]
nsprpub v2

I'm giving this an r+ in principle.  But the master source repository for NSPR is CVS, so I'll know for sure if this applies cleanly when I convert this patch to a CVS patch.
Attachment #441579 - Flags: review?(nelson) → review+
"judgement" actually is a valid, if less-common, spelling, just so you know.  I don't mind the change, but quite strictly speaking it's unnecessary.
(In reply to comment #61)
> (From update of attachment 441571 [details] [diff] [review])
> didn't we agree on nonexistent instead of non-existent? :(
> 
> X-nonexistent
> should be
> X-Nonexistent
> to match the style.

missed that, sorry.

(In reply to comment #65)
> (From update of attachment 441584 [details] [diff] [review])
> sorry
> 
> libimg/png is a third party library
> http://sourceforge.net/tracker/?atid=105624&group_id=5624&func=browse
> 
> modules/zlib is http://www.gzip.org/zlib/zlib_faq.html#faq08
> 
> everything else is fine.

I'll file bugs when I get home this evening (CET). Also I'll update the other patches. I thought I'd do the change from non-existent to nonexistent in a future patch since this is used over all components. But I'll update these patches to nonexistent, sorry for this misunderstanding.

Thanks for using that much time to review, timeless. :)

Nelson, could you please change the nit from comment 64 when converting to a CVS patch?
Attached patch js v3 (obsolete) — Splinter Review
Attachment #441574 - Attachment is obsolete: true
Attachment #441708 - Flags: review?(timeless)
Attached patch layout/media v3 (obsolete) — Splinter Review
Attachment #441576 - Attachment is obsolete: true
Attachment #441710 - Flags: review?(timeless)
Comment on attachment 441708 [details] [diff] [review]
js v3

for components which are hard to change (nss, nspr), it makes sense to roll non-existent => nonexistent changes together. for this patch, it's ok to get it later.
Attachment #441708 - Flags: review?(timeless) → review+
Attachment #441710 - Flags: review?(timeless) → review-
Comment on attachment 441710 [details] [diff] [review]
layout/media v3

sorry... liboggplay is part of the same xiph stuff

https://trac.xiph.org/
I will file bugs with patches in the upstreams' tracker. Right now I can't do it because I'm heading to school.

BTW, is there any list of third-party-libraries I could use for future patches to save time for you, timeless?
Do you have a list of misspelled words that you're planning to correct but
have not yet corrected?  If so, would you put it in a comment here?  
I'd rather fix the entire list all at once for NSS and NSPR, using the 
CVS trunk as the basis.
(In reply to comment #75)
> Do you have a list of misspelled words that you're planning to correct but
> have not yet corrected?  If so, would you put it in a comment here?  
> I'd rather fix the entire list all at once for NSS and NSPR, using the 
> CVS trunk as the basis.

see comment 60. Is it easier for you to convert a hg patch to a cvs patch or do you do the patch yourself?
Attachment #441588 - Attachment is obsolete: true
Attached patch dom v3 (obsolete) — Splinter Review
Attachment #441571 - Attachment is obsolete: true
Attachment #441842 - Flags: review?(timeless)
Attached patch modules/netwerk v3 (obsolete) — Splinter Review
Attachment #441584 - Attachment is obsolete: true
Attachment #441843 - Flags: review?(timeless)
Attached patch layout v4 (obsolete) — Splinter Review
This patch was "layout/media v3" before the update, now there is no code from media in there any more.
Attachment #441710 - Attachment is obsolete: true
Attachment #441844 - Flags: review?(timeless)
Comment on attachment 441842 [details] [diff] [review]
dom v3

-* Seperated internal stuff from get() into set()
+* separated internal stuff from get() into set()

You case folded :(

Sorry, but i believe this is the last round of minuses :)
Attachment #441842 - Flags: review?(timeless) → review-
Attachment #441843 - Flags: review?(timeless) → review+
Attachment #441844 - Flags: review?(timeless) → review+
Attached patch dom v4 (obsolete) — Splinter Review
oh, missed that.
Attachment #441842 - Attachment is obsolete: true
Attachment #441938 - Flags: review?(timeless)
Attachment #441938 - Flags: review?(timeless) → review+
Final review. I really hope I didn't screw up doing this patch (at least it applies).

The part from /content/media/ogg/nsOggDecoder.h I corrected has been moved to /content/media/ogg/nsOggPlayStateMachine.h in bug 560708. I have fixed it in the nsOggPlayStateMachine.h file.

For all the fixes please see comment 20.
Attachment #441369 - Attachment is obsolete: true
Attachment #441370 - Attachment is obsolete: true
Attachment #441371 - Attachment is obsolete: true
Attachment #441372 - Attachment is obsolete: true
Attachment #441383 - Attachment is obsolete: true
Attachment #441572 - Attachment is obsolete: true
Attachment #441579 - Attachment is obsolete: true
Attachment #441582 - Attachment is obsolete: true
Attachment #441585 - Attachment is obsolete: true
Attachment #441708 - Attachment is obsolete: true
Attachment #441843 - Attachment is obsolete: true
Attachment #441844 - Attachment is obsolete: true
Attachment #441938 - Attachment is obsolete: true
Attachment #442554 - Flags: review?(timeless)
Comment on attachment 442554 [details] [diff] [review]
final misspellings patch [fixes described in comment 20]

i was hoping you'd fold in the nonexistent collapsing change too, but oh well.

+    this.assertElementsMatch(Selector.matchElements($('fixtures').descendants(), '.inexistent, a.internal'), '#link_1', '#link_2');

should be nonexistent

dom/tests/mochitest/dom-level2-core

this somehow came from something in w3. We should be sending it upstream. konigsberg has some w3 stuff, i'm not sure if it has an index of the right thing for this.

http://mxr-test.konigsberg.mozilla.org/dev-w3/source/2001/DOM-Test-Suite/tests/level2/html/

seems close. Sorry for not spotting it earlier. Can you split the mochitest changes that seem to be w3 derived into its own patch and try to offer it to w3.org? hsivonen should be able to help.

+    // Check that annotation to a not existent page has been removed

an annotation/non-existing

+    // Add a bookmark using a not existent keyword

non-existing

actually for that whole file that's generally the right replacement.

sorry about this. you might as well make the full set of changes here. 

i'm stuck reading the whole thing start to finish anyway (and it's my fault, since i should have caught all of this much earlier)
Attachment #442554 - Flags: review?(timeless) → review-
regarding comment 83, 
surely "nonexistent" is preferable to "non-existing", no?
Comment on attachment 441423 [details] [diff] [review]
NSS patch for the alternative priviledge->privilege fix (committed)

Checking in certhigh/certvfy.c; new revision: 1.70; previous revision: 1.69
Checking in cryptohi/keythi.h;  new revision: 1.12; previous revision: 1.11
Checking in cryptohi/seckey.c;  new revision: 1.53; previous revision: 1.52
Attachment #441423 - Attachment description: NSS patch for the alternative priviledge->privilege fix → NSS patch for the alternative priviledge->privilege fix (committed)
In comment 69, Timeless wrote:
> Nelson, could you please change the nit from comment 64 when converting 
> to a CVS patch?

That comment (64) was too terse for me.  Please tell me
- what file
- old string
- new string
and I'll do it
(In reply to comment #83)
> (From update of attachment 442554 [details] [diff] [review])
> i was hoping you'd fold in the nonexistent collapsing change too, but oh well.
>
> +   
> this.assertElementsMatch(Selector.matchElements($('fixtures').descendants(),
> '.inexistent, a.internal'), '#link_1', '#link_2');
> 
> should be nonexistent

oh, yes. And I will change all non-existent to nonexistent in this patch if they are in a line that is edited anyway. The other cases I'll replace in another patch next week.You wrote in this comment "nonexistent" and "non-existent", which should I use? I'd like to use one in every file and not component-specific.


> dom/tests/mochitest/dom-level2-core
> 
> this somehow came from something in w3. We should be sending it upstream.
> konigsberg has some w3 stuff, i'm not sure if it has an index of the right
> thing for this.
> 
> http://mxr-test.konigsberg.mozilla.org/dev-w3/source/2001/DOM-Test-Suite/tests/level2/html/
> 
> seems close. Sorry for not spotting it earlier. Can you split the mochitest
> changes that seem to be w3 derived into its own patch and try to offer it to
> w3.org? hsivonen should be able to help.

I will check with him and make a new patch on Monday.
(In reply to comment #86)
> In comment 69, Timeless wrote:
> > Nelson, could you please change the nit from comment 64 when converting 
> > to a CVS patch?
> 
> That comment (64) was too terse for me.  Please tell me
> - what file
> - old string
> - new string
> and I'll do it

nevermind ;) I thought the "occuring" was in NSPR, but it was in the parser, so it was my assignment. Thanks anyway.
philor: Why aren't your changesets part of this bug?

http://hg.mozilla.org/mozilla-central/rev/a7cbd999c2f5
http://hg.mozilla.org/mozilla-central/rev/67b93e5e8f5d
http://hg.mozilla.org/mozilla-central/rev/6ffa228a5897

Perhaps you should coordinate with Michael so you don't bitrot him.
I don't think we should be messing with the third-party-imported mochitests at all.  That includes all of the w3c test suites, the jquery stuff, etc, etc.
Attached patch misspellings (obsolete) — Splinter Review
* changed to nits from comment 83
* deleted already checked in changes (see comment 90)
* deleted all changes to dom/tests/mochitest/ (see comment 91)
Attachment #442554 - Attachment is obsolete: true
Attachment #443704 - Flags: review?(timeless)
Blocks: 564091
Attached patch misspellings part 2 (obsolete) — Splinter Review
this changes:

* judgement -> judgment
* associtation -> association
* sepcify/sepcifying -> specify/specifying
Attachment #443782 - Flags: review?(timeless)
Attachment #443783 - Flags: review?(nelson)
No longer blocks: 564091
Depends on: 564091
Attachment #443783 - Flags: review?(nelson) → review+
Comment on attachment 443782 [details] [diff] [review]
misspellings part 2

drop:
toolkit/components/feeds/test/xml/rss1/full_feed_not_bozo.xml

it's based on a real blog, we can't really revise history.
Attachment #443782 - Flags: review?(timeless) → review+
Attachment #443704 - Flags: review?(timeless) → review+
Attachment #443704 - Attachment is obsolete: true
Attachment #444690 - Flags: review+
Attachment #443782 - Attachment is obsolete: true
Attachment #444691 - Flags: review+
Keywords: checkin-needed
Whiteboard: [please do not mark this bug as fixed after checkin]
Depends on: 561956
Comment on attachment 444690 [details] [diff] [review]
misspellings part 1 [checked in]

http://hg.mozilla.org/mozilla-central/rev/7ef2a4732afe
Attachment #444690 - Attachment description: misspellings part 1 [for checking] → misspellings part 1 [checked in]
Comment on attachment 444691 [details] [diff] [review]
misspellings part 2 [checked in]

http://hg.mozilla.org/mozilla-central/rev/11ef0c724251
Attachment #444691 - Attachment description: misspellings part 2 [for checking] → misspellings part 2 [checked in]
Keywords: checkin-needed
Whiteboard: [please do not mark this bug as fixed after checkin]
Depends on: 566552
Depends on: 566613
Attached patch Misspellings Part 3 (obsolete) — Splinter Review
shoud -> should
paltform -> platform
paramter -> parameter
exlude -> exclude
Attachment #452291 - Flags: review?
Attachment #452291 - Flags: review? → review?(timeless)
Attached patch NSS misspellings (obsolete) — Splinter Review
Changes see comment above.
Attachment #452292 - Flags: review?(nelson)
Attachment #452291 - Flags: review?(timeless) → review+
Comment on attachment 452291 [details] [diff] [review]
Misspellings Part 3

>+++ b/uriloader/exthandler/win/nsOSHelperAppService.cpp	Fri >+// Strip a handler command string of it's quotes and parameters.

s/it's/its/
Attached patch Misspellings Part 3 v2 (obsolete) — Splinter Review
Corrected: s/it's/its

Also pushed to try server as http://hg.mozilla.org/try/rev/f57476abee09 to be sure I don't break anything with this. BTW, is this try-checkin correct or should I do something different next time? (was my first push)
Attachment #452291 - Attachment is obsolete: true
Attachment #456000 - Flags: review+
Keywords: checkin-needed
Comment on attachment 456000 [details] [diff] [review]
Misspellings Part 3 v2

sorry, please exclude libvpx. I'm not sure where the upstream is, but i'm sure there is one. you can split out a bug to video/audio and get one of the video/audio people to deal w/ it, or find the upstream directly.
Attachment #456000 - Flags: review-
Attached patch Patch 3.3Splinter Review
(In reply to comment #107)
> (From update of attachment 456000 [details] [diff] [review])
> sorry, please exclude libvpx. I'm not sure where the upstream is, but i'm sure
> there is one. you can split out a bug to video/audio and get one of the
> video/audio people to deal w/ it, or find the upstream directly.

As far as I see the upstream lives at http://www.webmproject.org/code/ . Filed a bug there with the patch attached.
Attachment #456000 - Attachment is obsolete: true
Attachment #456267 - Flags: review+
Alias: spelling
Please report new misspellings in bug 577266 . If they are only in nspr or nss present, please report them to bug 577267 or bug 577268. Thanks.
Attachment #452292 - Attachment is obsolete: true
Attachment #452292 - Flags: review?(nelson)
No longer depends on: 241181
Pushed as http://hg.mozilla.org/mozilla-central/rev/a9356e0479d1 .
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.