Closed
Bug 506079
Opened 15 years ago
Closed 15 years ago
[FreeBSD] Build bustage in updater
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 535942
People
(Reporter: mpk, Unassigned)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
759 bytes,
patch
|
robert.strong.bugs
:
review-
|
Details | Diff | Splinter Review |
Since the fix for bug 458950 landed, builds on FreeBSD are broken:
[...]
gmake[8]: Entering directory `/work/build/browser/toolkit/mozapps/update/src'
gmake[9]: Entering directory `/work/build/browser/toolkit/mozapps/update/src/updater'
updater.cpp
bspatch.cpp
c++ -o bspatch.o [...] /work/src/mozilla/toolkit/mozapps/update/src/updater/bspatch.cpp
c++ -o updater.o [...] /work/src/mozilla/toolkit/mozapps/update/src/updater/updater.cpp
archivereader.cpp
c++ -o archivereader.o -c -I../../../../../dist/system_wrappers -include /work/src/mozilla/config/gcc_hidden.h -DOSTYPE=\"FreeBSD7\" -DOSARCH=FreeBSD -DNS_NO_XPCOM -I/work/src/mozilla/toolkit/mozapps/update/src/updater -I. -I../../../../../dist/include -I../../../../../dist/include/nsprpub -I/work/build/browser/dist/include/nspr -I/work/build/browser/dist/include/nss -I/usr/local/include -fPIC -I/usr/local/include -I/usr/local/include -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -fno-strict-aliasing -fshort-wchar -pipe -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/gtk-unix-print-2.0 -DNDEBUG -DTRIMMED -O -I/usr/local/include -I/usr/local/include -DMOZILLA_CLIENT -include ../../../../../mozilla-config.h -Wp,-MD,.deps/archivereader.pp /work/src/mozilla/toolkit/mozapps/update/src/updater/archivereader.cpp
/work/src/mozilla/toolkit/mozapps/update/src/updater/updater.cpp: In function 'int copy_file(const char*, const char*)':
/work/src/mozilla/toolkit/mozapps/update/src/updater/updater.cpp:465: error: base operand of '->' has non-pointer type 'AutoFile'
/work/src/mozilla/toolkit/mozapps/update/src/updater/updater.cpp: In function 'int DoUpdate()':
/work/src/mozilla/toolkit/mozapps/update/src/updater/updater.cpp:1529: error: base operand of '->' has non-pointer type 'AutoFile'
gmake[9]: *** [updater.o] Error 1
gmake[9]: *** Waiting for unfinished jobs....
gmake[9]: Leaving directory `/work/build/browser/toolkit/mozapps/update/src/updater'
gmake[8]: *** [libs] Error 2
[...]
Updated•15 years ago
|
Summary: Build bustage in updater → [FreeBSD] Build bustage in updater
Reporter | ||
Comment 1•15 years ago
|
||
Attaching Thinker's patch from bug 522478.
(Thinker, I hope you don't mind :-)
Attachment #419749 -
Flags: review?(robert.bugzilla)
Reporter | ||
Comment 2•15 years ago
|
||
The landing for bug 542222 (changeset 37934:2d873df39b6a) broke the
original patch. This one has the path corrected.
Attachment #419749 -
Attachment is obsolete: true
Attachment #425627 -
Flags: review?(robert.bugzilla)
Attachment #419749 -
Flags: review?(robert.bugzilla)
Comment 3•15 years ago
|
||
Comment on attachment 425627 [details] [diff] [review]
patch v2 for unbreaking builds in updater (mozilla-central)
This will be fixed by bug 535942 so minusing
Attachment #425627 -
Flags: review?(robert.bugzilla) → review-
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•