522478 - xulrunner can not be build on FreeBSD Host

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Thinker]

User-Agent:       Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.2) Gecko/20090902 Firefox/3.5.2
Build Identifier: changeset #285620e65ac3 from mercurial repository

I build xulrunner on my FreeBSD host.  But, it is fail to build it.  It stops at media/liboggplay/src/liboggplay/oggplay.c.  And I found, mozilla tries to define oggz_off_t as loff_t.  But, FreeBSD has only off_t, just like Apple, Solaris, and OS2.  So, I made a simple patch, and it seems works fine.



Reproducible: Always




oggz_off_t should be off_t for FreeBSD

diff -r 0b404b342279 -r 285620e65ac3 media/liboggz/include/oggz/oggz_off_t_generated.h
--- a/media/liboggz/include/oggz/oggz_off_t_generated.h	Mon Oct 12 13:07:51 2009 +1300
+++ b/media/liboggz/include/oggz/oggz_off_t_generated.h	Thu Oct 15 22:53:20 2009 +0800
@@ -59,7 +59,8 @@
 
 #include <sys/types.h>
 
-#if defined(__APPLE__) || defined(SOLARIS) || defined(OS2)
+#if defined(__APPLE__) || defined(SOLARIS) || defined(OS2) || \
+    defined(__FreeBSD__)
 typedef off_t oggz_off_t;
 #else
 typedef loff_t oggz_off_t;

Comment 1

[Thinker]

Attachment: local patch

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to comment #1)
> Created an attachment (id=406452) [details]
> local patch

We maintain all our changes to the external media libraries as patches, which we apply with the update.sh scripts whenever we update the media libraries. Your patch needs to change update.sh, README_MOZILLA, and add a patch file to the media/liboggz/.

See the patch https://bug448918.bugzilla.mozilla.org/attachment.cgi?id=383099 in bug 448918 for an example.

Comment 3

[cajbir (:cajbir)]

Also see bug 449066 about building on bsd.

Comment 4

[Thinker]

Attachment: fix bug522478

This patch includes patches for oggz_off_t, update.sh, and README_MOZILLA.

Comment 5

[cajbir (:cajbir)]

This fix was already in bug 449066 and reviewed and was waiting for the patch author to do the update.sh, README_MOZILLA work. Are the other patches in that bug needed for BSD to compile also?

Comment 6

[Thinker]

Attachment: patch of updater

toolkit/mozapps/update/src/updater/updater.cpp should also be patched.  Since, fileno() of FreeBSD is not totally matched with POSIX for thread-safe version.  It needs a explicitly casting to FILE * for AutoFile type when passing an AutoFile to fileno().  With this patch, I can build xulrunner successfully.

Comment 7

[Marco Perez [:mpk]]

Comment on attachment 406650 [details] [diff] [review]
patch of updater

Attachment 406650 [details] [diff] does indeed fix a bug (as already described in bug 506079).
It works on both FreeBSD7 and FreeBSD8 (i386 as well as amd64). In case it
doesn't break the builds on any of the other platforms (can't test it myself),
would it be possible to have it landed on trunk?

Comment 8

[Robert Strong (they/them - no direct email)]

(In reply to comment #6)
> Created an attachment (id=406650) [details]
> patch of updater
> 
> toolkit/mozapps/update/src/updater/updater.cpp should also be patched.  Since,
> fileno() of FreeBSD is not totally matched with POSIX for thread-safe version. 
> It needs a explicitly casting to FILE * for AutoFile type when passing an
> AutoFile to fileno().  With this patch, I can build xulrunner successfully.
Thinker, could you instead upload the updater patch to bug 506079? Thanks.

Comment 9

[Marco Perez [:mpk]]

Comment on attachment 406650 [details] [diff] [review]
patch of updater

Attached the updater patch to bug 506079. (Thinker, I hope you don't mind :-)

Comment 10

[Marco Perez [:mpk]]

This bug seems to have been fixed some months ago. For details please see:
 - bug 535942
 - bug 556455