506569 - Content-box on a prefpane is cutoff on Windows systems using the classic theme

Status: RESOLVED WORKSFORME

(Toolkit :: Themes, defect)

Description

[Gabriele Best [:Gabri]]

There is a bug under Windows systems that use the classic theme: the content-box included into a prefpane-prefwindow is cutoff and not all the options are visible by the user.

I've already found the problem and the related patch, I'll sent it soon.

Comment 1

[Gabriele Best [:Gabri]]

Attachment: Proposed patch (3.5 branch only)

This bug was caused by the patch of bug 69710 which also included an hack to work around bug 458231. I've removed that work around because now it's useless (that bug was fixed), this patch doesn't change the firefox's behaviour about bug 69710, just fix this bug.

Comment 2

[Dão Gottwald [:dao]]

This should already be fixed on trunk. I don't think your patch applies.

Comment 3

[Gabriele Best [:Gabri]]

On the trunk it's already fixed and working properly now but on the 3.5 branch this problem still exists and a user reported me it.

This patch is only for the branch (and it's a bit different from the trunk one) and I hope you'll review it because this bug makes some addons unusable.

Thanks.

Comment 4

[[e-mail]]

(In reply to comment #3)
> This patch is only for the branch (and it's a bit different from the trunk one)
> and I hope you'll review it because this bug makes some addons unusable.
But bug 458231 wasn't fixed on the branch, so we still need a workaround...
(not necessarily the one that we have, but we need one nonetheless)

Comment 5

[Gabriele Best [:Gabri]]

Attachment: Screenshot - Workaround useless?

About the workaround:
In this screenshot (testcase of bug 458231) you can see the difference between trunk (bug 458231 fixed) and the branch (with the workaround). The result is simple: the current workaround is useless (I think) and we can remove that for now (resolving this bug) and if we need another workaround we can open a new bug.

From bug 69710 comment 18: that workaround was made to avoid the change of size of the checkboxes and radios when disabled (applying a transparent text-shadow when they are enabled and a minor margin when they are disabled), see attachment 342627 [details] . That workaround resolved the problem but it created this new one (Content-box on a prefpane is cutoff), with my patch that problem (size of the checkboxes and radios) remains fixed resolving also this bug.

Comment 6

[[e-mail]]

(In reply to comment #5)
> Created an attachment (id=390859)
> Screenshot - Workaround useless?
The workaround does not even apply to the markup that you took a screenshot of, as that only uses raw <label> elements, not checkboxes or radiogroups.

On the other hand, if I take a screenshot of SeaMonkey's Location Bar preferences, comparing latest-comm-1.9.1 and latest-comm-trunk builds, there is no difference in the rendering of the checkboxes.

Comment 7

[Gabriele Best [:Gabri]]

(In reply to comment #6)
> (In reply to comment #5)
> > Created an attachment (id=390859) [details]
> > Screenshot - Workaround useless?
> The workaround does not even apply to the markup that you took a screenshot of,
> as that only uses raw <label> elements, not checkboxes or radiogroups.

I know that, the workaround was made ONLY to prevent the change of size
of the checkboxes and radios when disabled (attachment 342627 [details], bug 69710 comment 18) but it caused this new bug.

With the patch, as you can see, the current behaviour doesn't change and this bug is fixed.

I hope you can review it soon :)

Comment 8

[[e-mail]]

OK, so your patch doesn't completely remove the workaround for bug 458231, it still applies it for disabled checkboxes; I assume that this helps in your case because the pane in question doesn't have any disabled checkboxes or else they get disabled at a later point where the issue does not occur?

Comment 9

[Gabriele Best [:Gabri]]

I've just tried to insert some disabled checkboxes into the prefpane and the problem doesn't appear so I think this patch working in some cases.

Comment 10

[[e-mail]]

Sorry, but I've tried to write a number of test cases for your patch and failed to notice any difference in behaviour. If I can't find any justification for taking this patch I'll have to ask you to get someone else to look at it.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:dao, could you have a look please?
For more information, please visit auto_nag documentation.