Closed
Bug 506818
Opened 16 years ago
Closed 16 years ago
Review/expand/improve validation help text
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect)
addons.mozilla.org Graveyard
Developer Pages
Tracking
(Not tracked)
VERIFIED
FIXED
5.0.9
People
(Reporter: clouserw, Unassigned)
References
()
Details
Attachments
(1 file)
2.61 KB,
patch
|
Details | Diff | Splinter Review |
RJ wrote a bunch of help for our validation tests but it's a lot for one person to do and it should be looked at and expanded where helpful.
I'll take the first run at this and then hand the bug off to someone else
Reporter | ||
Comment 1•16 years ago
|
||
The URL for this page is https://preview.addons.mozilla.org/en-US/firefox/pages/validation
My changes are in r30532. I'm trying to balance helpfulness with too much detail. I don't want to have to update this page every time we tweak a test so I'd rather not list all the details for each test. On the other hand, there is a [help] link next to each test and this is what people will see if their test fails so we need to be clear about what the problem was.
Happy to have more input. I'm CCing a pile of people who may have an interest in tweaking the language here. If you start making serious changes that may conflict please take the bug so other people know you are working on it. Thanks.
Comment 2•16 years ago
|
||
I mentioned this in IRC, but I looked over it with my annoying-English-major eye and it all looked good to me; it also seemed to have the right balance, FWIW.
I just noticed three very minor problems.
1. “the the” in the first paragraph.
2. <p> contains <ul> in two places, but this is not valid in XHTML 1.0.
3. The second sentence in the section “General Tests” reads:
> They include ensuring that ..., that ..., and it can be extracted and installed.
A “that” is omitted only in the third item, and it looks inconsistent to me (but I am not a native speaker of English).
Attached is a trivial patch which fixes them.
Reporter | ||
Comment 5•16 years ago
|
||
It's been a week. I assume everyone has had a chance to look at this. ->fixed
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: 5.0.8 → 5.0.9
Comment 6•16 years ago
|
||
I'm calling this good too; fcp's comments have been addressed, and we can always file new bugs for other tweaks.
Status: RESOLVED → VERIFIED
Assignee | ||
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•