Closed Bug 506955 Opened 13 years ago Closed 13 years ago

Support the -private command line option even when Firefox is already running

Categories

(Firefox :: Private Browsing, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.7a1

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

jmathies says that this is required for supporting Win7's Jump List feature, so I'm filing the bug.  This will depend on bug 471997 which adds support for this command line argument.
Attached patch Patch (v1) (obsolete) — Splinter Review
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #395292 - Flags: review?(mconnor)
Whiteboard: [needs r=mconnor]
Comment on attachment 395292 [details] [diff] [review]
Patch (v1)

Making this a toggle feels wrong, since it means that if I have a shortcut to launch in PB, launching again disables it... not what we want.

If we want to support this as an external way to toggle behaviour that we should have two flags (explicit flags, not implicit).
Attachment #395292 - Flags: review?(mconnor) → review-
No longer blocks: 473045
Blocks: 518666
No longer blocks: 518666
Blocks: 519985
Attached patch Patch (v2) (obsolete) — Splinter Review
Switch to the -private-toggle command line option.
Attachment #395292 - Attachment is obsolete: true
Attachment #404219 - Flags: review?(mconnor)
Attached patch Patch (v3)Splinter Review
Fix a unit test failure with the new patch.
Attachment #404219 - Attachment is obsolete: true
Attachment #404226 - Flags: review?(mconnor)
Attachment #404219 - Flags: review?(mconnor)
Comment on attachment 404226 [details] [diff] [review]
Patch (v3)

r=me, sorry for the delay
Attachment #404226 - Flags: review?(mconnor) → review+
Whiteboard: [needs r=mconnor]
http://hg.mozilla.org/mozilla-central/rev/2eba6b8580c6
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
I broke the tree, and then fixed it in: http://hg.mozilla.org/mozilla-central/rev/9c68bcd8515e
Depends on: 568816
No longer depends on: 568816
You need to log in before you can comment on or make changes to this bug.