Closed
Bug 506955
Opened 15 years ago
Closed 15 years ago
Support the -private command line option even when Firefox is already running
Categories
(Firefox :: Private Browsing, defect)
Firefox
Private Browsing
Tracking
()
RESOLVED
FIXED
Firefox 3.7a1
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
11.34 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
jmathies says that this is required for supporting Win7's Jump List feature, so I'm filing the bug. This will depend on bug 471997 which adds support for this command line argument.
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs r=mconnor]
|
||
Comment 2•15 years ago
|
||
Comment on attachment 395292 [details] [diff] [review]
Patch (v1)
Making this a toggle feels wrong, since it means that if I have a shortcut to launch in PB, launching again disables it... not what we want.
If we want to support this as an external way to toggle behaviour that we should have two flags (explicit flags, not implicit).
Attachment #395292 -
Flags: review?(mconnor) → review-
|
|
Assignee | |
Comment 3•15 years ago
|
||
Switch to the -private-toggle command line option.
Attachment #395292 -
Attachment is obsolete: true
Attachment #404219 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 4•15 years ago
|
||
Fix a unit test failure with the new patch.
Attachment #404219 -
Attachment is obsolete: true
Attachment #404226 -
Flags: review?(mconnor)
Attachment #404219 -
Flags: review?(mconnor)
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 404226 [details] [diff] [review]
Patch (v3)
r=me, sorry for the delay
Attachment #404226 -
Flags: review?(mconnor) → review+
|
|
||
Updated•15 years ago
|
Whiteboard: [needs r=mconnor]
|
|
Assignee | |
Comment 6•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
|
|
Assignee | |
Comment 7•15 years ago
|
||
I broke the tree, and then fixed it in: http://hg.mozilla.org/mozilla-central/rev/9c68bcd8515e
You need to log in
before you can comment on or make changes to this bug.
Description
•