519985 - Define additional jump lists items for Firefox

Status: NEW

(Firefox :: Shell Integration, defect)

Description

[Jim Mathies [:jimm]]

A number of folks have been making suggestions on tasks for the task list as well as secondary lists to favorites and frequent for win7's jump list for firefox. Filing this meta bug for discussion of possible additions and behavior that the ui guys can approve/disapprove. Items that are approved will have bugs filed off to try and get them added.

Current list of jump lists tasks when browser is open:
Open new tab
Open new window

Current list of jump lists tasks when browser is open:
(empty)

Possible additions:

launch in private mode (must have for parity with ie8, bug 506955)
launch directly to preferred search engine
open last closed tab
linksbar links list
restore last session / open without restore

Comment 1

[Jim Mathies [:jimm]]

I should also add a caveat, crazy custom lists can easily be handled by extensions. Features suggested here should be common tasks a majority of users would find helpful.

Extension developers can disable firefox's default jump list handling via the browser.taskbar.lists.enabled pref to prevent conflict.

Comment 2

[Jim Mathies [:jimm]]

Tasks:
(Close and) Open in safe mode
Open bookmarks manager

Comment 3

[Jim Mathies [:jimm]]

Attachment: privacy mode patch v.1

- add a privacy toggle switch to tasks

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 446225 [details] [diff] [review]
privacy mode patch v.1

Note, converting over to the new Services.jsm is bug 566856, so I'm still doing this manually here.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 446225 [details] [diff] [review]
privacy mode patch v.1

>+  {
>+    get title() {
>+         if (_privateBrowsingSvc.privateBrowsingEnabled)
>+           return _getString("taskbar.tasks.exitPrivacyMode.label")
>+         else
>+           return _getString("taskbar.tasks.enterPrivacyMode.label")},
>+    get description() {
>+         if (_privateBrowsingSvc.privateBrowsingEnabled)
>+           return _getString("taskbar.tasks.exitPrivacyMode.description")
>+         else
>+           return _getString("taskbar.tasks.enterPrivacyMode.description")},

nits:
- the function bodies are indented too far
- semicolon should be added after the return statements
- line break needed before '}'

Comment 6

[(no longer active)]

Comment on attachment 446225 [details] [diff] [review]
privacy mode patch v.1

Is this code resilient to dynamic private browsing mode changes?

Comment 7

[Jim Mathies [:jimm]]

Attachment: updated patch

Comment 8

[Jim Mathies [:jimm]]

(In reply to comment #6)
> (From update of attachment 446225 [details] [diff] [review])
> Is this code resilient to dynamic private browsing mode changes?

yes, it updates the list when the state changes via an observer event.

Comment 9

[(no longer active)]

(In reply to comment #8)
> (In reply to comment #6)
> > (From update of attachment 446225 [details] [diff] [review] [details])
> > Is this code resilient to dynamic private browsing mode changes?
> 
> yes, it updates the list when the state changes via an observer event.

Where?  Unless there's something wrong with my eyes, you're actually removing that observer.  :-)

Comment 10

[Jim Mathies [:jimm]]

(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #6)
> > > (From update of attachment 446225 [details] [diff] [review] [details] [details])
> > > Is this code resilient to dynamic private browsing mode changes?
> > 
> > yes, it updates the list when the state changes via an observer event.
> 
> Where?  Unless there's something wrong with my eyes, you're actually removing
> that observer.  :-)

it still calls "this.update()" down at the bottom. I just removed the variable as it's not used anymore.

Comment 11

[Jim Mathies [:jimm]]

privacy mode toggle:
http://hg.mozilla.org/mozilla-central/rev/47b733ac1c7e

Comment 12

[tymerkaev]

Please add "Downloads" and "Add-ons" menu items. Probably will be good add item "Work Offline".

Comment 13

[u88484]

(In reply to comment #12)
> Please add "Downloads" and "Add-ons" menu items. Probably will be good add item
> "Work Offline".

Just for reference, the work offline menu option is near the bottom of the list of frequently used menu items.  While add-ons is the top entry and downloads is shortly after.

http://blog.mozilla.com/metrics/2010/04/14/menu-item-usage-study-an-update-to-the-initial-analysis/
http://blog.mozilla.com/metrics/2010/04/23/menu-item-usage-study-the-80-20-rule/

Comment 14

[[not reading bugmail]]

There appear to be an issue here.. 

My jumplist item didn't change if I start PB mode using the FF Tools Menu.  If I Start using the tools menu, the tasklist shows Enter Private Browsing Mode and proceeds to Quit my private session.

Comment 15

[Jim Mathies [:jimm]]

(In reply to comment #14)
> There appear to be an issue here.. 
> 
> My jumplist item didn't change if I start PB mode using the FF Tools Menu.  If
> I Start using the tools menu, the tasklist shows Enter Private Browsing Mode
> and proceeds to Quit my private session.

Odd, we're hooked up to the observer for this. I'll take a look.

Comment 16

[Jim Mathies [:jimm]]

(In reply to comment #15)
> (In reply to comment #14)
> > There appear to be an issue here.. 
> > 
> > My jumplist item didn't change if I start PB mode using the FF Tools Menu.  If
> > I Start using the tools menu, the tasklist shows Enter Private Browsing Mode
> > and proceeds to Quit my private session.
> 
> Odd, we're hooked up to the observer for this. I'll take a look.

Seems to be working here.

1) open browser
2) select start privacy mode
(check jump list title)
3) select quit privacy mode
(check jump list title)

In both cases, the title is correct.

I filed bug 568816 on a related problem, exiting privacy mode via the menu item after entering it via the command line option doesn't appear to work.

Comment 17

[[not reading bugmail]]

(In reply to comment #16)
> (In reply to comment #15)
> > (In reply to comment #14)
> > > There appear to be an issue here.. 
> > > 
> > > My jumplist item didn't change if I start PB mode using the FF Tools Menu.  If
> > > I Start using the tools menu, the tasklist shows Enter Private Browsing Mode
> > > and proceeds to Quit my private session.
> > 
> > Odd, we're hooked up to the observer for this. I'll take a look.
> 
> Seems to be working here.
> 
> 1) open browser
> 2) select start privacy mode
> (check jump list title)
> 3) select quit privacy mode
> (check jump list title)
> 
> In both cases, the title is correct.
> 
> I filed bug 568816 on a related problem, exiting privacy mode via the menu item
> after entering it via the command line option doesn't appear to work.

Thanks.  I see the problem I was having is related to deleting items from the Jumplist Freq/Recent section using "Remove from this list" and switching profiles corrected the issue after doing some investigation (bug 568694).

Comment 18

[[not reading bugmail]]

Would we be able to add startup with profile manager, or startup in safe mode to the list?