Closed Bug 507122 Opened 11 years ago Closed 11 years ago

toolbar style don't match Firefox

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
Windows Vista
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b4

People

(Reporter: andreasn, Assigned: andreasn)

References

Details

Attachments

(2 files, 2 obsolete files)

The style of the toolbar, with a line between the menu and toolbar, don't match the one on Firefox that sports a more united appearance.
Attached patch patch on trunk (obsolete) — Splinter Review
Here is a patch that fixes this issue.
Blocks: 488060
Attachment #391330 - Flags: ui-review?(clarkbw)
Has this been testing in XP?  maybe I can get philor to look at this in XP

I like the new toolbar look but I'm wondering if we need a messenger-aero.css file when the difference of the two is so small.

Here's what I have for the diff of the two files:

--- messenger.css       Wed Aug  5 09:54:45 2009
+++ messenger-aero.css  Wed Aug  5 09:54:45 2009
@@ -13,7 +13,9 @@

 .toolbar-primary {
   -moz-binding: url("chrome://global/content/bindings/toolbar.xml#toolbar");
+  -moz-appearance: none;
   border-top-style: none;
+  border-top-width: 0px;
 }

I've included an alternate style patch to this problem.  Essentially when most of the windows XP and Vista CSS is going to be shared we should be using this style that I learned from philor.

The differences are this:
jar.mn has a "*" in front of the line which tells the compile to pre-process the file.  Essentially meaning it will use the include to make the new file with all the CSS rules appended to the bottom of the new file.  This works really well for CSS.

messenger.css only has the different CSS rules that are needed for the Vista components.

What does suck about this is that from now on any line numbers related to CSS errors in Vista can be wrong.  However the aero override file should be small and if the line number is larger than the file you know you're looking at the aero file instead of the original included file.
maybe I should add philor if I want him to look at the patch
also you should try this one since my misspelling of messenger makes that other patch not work
Attachment #392747 - Attachment is obsolete: true
Comment on attachment 391330 [details] [diff] [review]
patch on trunk

minus for now until we get the code sorted out
Attachment #391330 - Flags: ui-review?(clarkbw) → ui-review-
Comment on attachment 392758 [details] [diff] [review]
fix spelling messs 

hmmm, `something clever` and can you take a look at this?
Attachment #392758 - Flags: review?(philringnalda)
Attachment #391330 - Attachment is obsolete: true
Comment on attachment 392758 [details] [diff] [review]
fix spelling messs 

Looks good to me.
Attachment #392758 - Flags: review?(philringnalda) → review+
http://hg.mozilla.org/comm-central/rev/1a2824475537
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b4
You need to log in before you can comment on or make changes to this bug.