507386 - Unintended semicolons at the end of if-statements.

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Blake Winton (:bwinton) (:☕️)]

Attachment: Remove two semicolons at the end of if statements [Checkin: See comment 4 & 7]

I was fixing a link in Thunderbird as part of bug 503436, and when I found out it occurred because of a semicolon at the end of an if:
  if (config.rememberPassword && config.incoming.password.length);
    rememberPassword(inServer, config.incoming.password);
So I grepped through the rest of the javascript files for "^[[:space:]]*if\b[^)]*\);", and it gave me two hits, which I've cleaned up in the attached diff.

Thanks,
Blake.

Comment 1

[Brendan Eich [:brendan]]

Comment on attachment 391590 [details] [diff] [review]
Remove two semicolons at the end of if statements
[Checkin: See comment 4 & 7]

Yow -- want jshydra or whatever to find stuff like this, yesterday.

/be

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 391590 [details] [diff] [review]
Remove two semicolons at the end of if statements
[Checkin: See comment 4 & 7]

r=me thanks for finding this.

re jshydra: we've just started to use it for finding dead code. i'll add this to the list.

Comment 3

[Brendan Eich [:brendan]]

Nominate for next release? Not sure how these bite users.

/be

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/4c8985a2e10b

Comment 5

[Samuel Sidler (old account; do not CC)]

Doesn't block but we'll take the patch if you can land it before code freeze (August 11).

Comment 6

[Samuel Sidler (old account; do not CC)]

Comment on attachment 391590 [details] [diff] [review]
Remove two semicolons at the end of if statements
[Checkin: See comment 4 & 7]

Approved for 1.9.1.3. a=ss for release-drivers

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 391590 [details] [diff] [review]
Remove two semicolons at the end of if statements
[Checkin: See comment 4 & 7]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/224d3db82d52

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed based on check-ins.

I wonder why the in-testsuite- flag is set. Given that bug we clearly lack a test in this area.