507595 - More vista styled appearance for the address book

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Andreas Nilsson (:andreasn)]

The current layout on Vista use a lot of thick borders compared to other applications. I want to rework this and make it more similar to the Organize Bookmarks window in Firefox 3.5

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: patch on trunk

Comment 2

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of patch in action

Ignore the icons for now, they are fixed as part of #489366.

We still need to figure out if we need to do a #include of the selectors shared between Vista and XP, as Bryan mentioned in #506633. If that is the case, I'll rework the patch.

Comment 3

[Andreas Nilsson (:andreasn)]

Attachment: Firefox Library window for comparision

Comment 4

[Joe Sabash [:JoeS1]]

While https://bugzilla.mozilla.org/attachment.cgi?id=391852 looks fine,
maybe you could have included a "Portrait of Dorian Gray" as well.
(Maybe in the first stages of degradation)
Sorry for the spam, I just couldn't resist.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 391850 [details] [diff] [review]
patch on trunk

We might want to do the same kind of %include override for this bug instead of copying a whole new file.

Also the border colors didn't seem to match the Vista theme border colors, can make make that part of this bug?

Comment 6

[Andreas Nilsson (:andreasn)]

Attachment: updated patch

make use of include-thingy

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 395563 [details] [diff] [review]
updated patch

looks good to me

Comment 8

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/6d86faed2dea

Comment 9

[Vlado Valastiak [:wladow]]

Attachment: 20090825 nightly

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.4pre) Gecko/20090825 Shredder/3.0b4pre

This needs a little more tweaking, the current build doesn't match attachment 391852 [details] and also comment 5 needs to be addressed (border color part)

So:
- dirTree-splitter width should be 1px
- CardViewOuterBox shouldn't have bottom and right border
- border colors should match Vista style

Comment 10

[Andreas Nilsson (:andreasn)]

I just noticed these issues as well, missed these because of odd building problems. Will fix.

Comment 11

[Andreas Nilsson (:andreasn)]

Attachment: new patch to fix the reopening issue

Sorry for missing this the first time around.

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 404608 [details] [diff] [review]
new patch to fix the reopening issue

much better

Comment 13

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/2ba64b8ebd49