More vista styled appearance for the address book

RESOLVED FIXED in Thunderbird 3.0rc1

Status

Thunderbird
Address Book
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: andreasn, Assigned: andreasn)

Tracking

Trunk
Thunderbird 3.0rc1
All
Windows Vista
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 1 obsolete attachment)

(Assignee)

Description

8 years ago
The current layout on Vista use a lot of thick borders compared to other applications. I want to rework this and make it more similar to the Organize Bookmarks window in Firefox 3.5
(Assignee)

Updated

8 years ago
Blocks: 488060
(Assignee)

Comment 1

8 years ago
Created attachment 391850 [details] [diff] [review]
patch on trunk
Attachment #391850 - Flags: ui-review?(clarkbw)
(Assignee)

Comment 2

8 years ago
Created attachment 391852 [details]
screenshot of patch in action

Ignore the icons for now, they are fixed as part of #489366.

We still need to figure out if we need to do a #include of the selectors shared between Vista and XP, as Bryan mentioned in #506633. If that is the case, I'll rework the patch.
Assignee: nobody → nisses.mail
Status: NEW → ASSIGNED
(Assignee)

Comment 3

8 years ago
Created attachment 391857 [details]
Firefox Library window for comparision

Comment 4

8 years ago
While https://bugzilla.mozilla.org/attachment.cgi?id=391852 looks fine,
maybe you could have included a "Portrait of Dorian Gray" as well.
(Maybe in the first stages of degradation)
Sorry for the spam, I just couldn't resist.
Comment on attachment 391850 [details] [diff] [review]
patch on trunk

We might want to do the same kind of %include override for this bug instead of copying a whole new file.

Also the border colors didn't seem to match the Vista theme border colors, can make make that part of this bug?
Attachment #391850 - Flags: ui-review?(clarkbw) → ui-review-
(Assignee)

Comment 6

8 years ago
Created attachment 395563 [details] [diff] [review]
updated patch

make use of include-thingy
Attachment #391850 - Attachment is obsolete: true
Attachment #395563 - Flags: ui-review?(clarkbw)
Attachment #395563 - Flags: review?(philringnalda)
Attachment #395563 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 395563 [details] [diff] [review]
updated patch

looks good to me
Attachment #395563 - Flags: review?(philringnalda) → review+
http://hg.mozilla.org/comm-central/rev/6d86faed2dea
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b4
Created attachment 396461 [details]
20090825 nightly

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.4pre) Gecko/20090825 Shredder/3.0b4pre

This needs a little more tweaking, the current build doesn't match attachment 391852 [details] and also comment 5 needs to be addressed (border color part)

So:
- dirTree-splitter width should be 1px
- CardViewOuterBox shouldn't have bottom and right border
- border colors should match Vista style
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 10

8 years ago
I just noticed these issues as well, missed these because of odd building problems. Will fix.
(Assignee)

Comment 11

8 years ago
Created attachment 404608 [details] [diff] [review]
new patch to fix the reopening issue

Sorry for missing this the first time around.
Attachment #404608 - Flags: ui-review?(clarkbw)
Attachment #404608 - Flags: review?(philringnalda)
Attachment #404608 - Flags: review?(philringnalda) → review+
Comment on attachment 404608 [details] [diff] [review]
new patch to fix the reopening issue

much better
Attachment #404608 - Flags: ui-review?(clarkbw) → ui-review+
Keywords: checkin-needed
Hardware: x86 → All
Attachment #404608 - Flags: approval-thunderbird3+
http://hg.mozilla.org/comm-central/rev/2ba64b8ebd49
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Thunderbird 3.0b4 → Thunderbird 3.0rc1

Updated

7 years ago
Depends on: 549306
You need to log in before you can comment on or make changes to this bug.