508143 - "Status Bar" and "Sort By" have redundant access keys / mnemonics in View menu

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[random832]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.1) Gecko/20090715 Thunderbird/3.0b3

Status Bar (showTaskbarCmd in utilityOverlay.dtd) and Sort By (sortMenu in messenger.dtd) both have "S" assigned to their access key though they appear in the same menu.

I have been using the key for Sort By for a long time, so Status Bar is the newcomer. Of letters appearing in the label, "a", "u", and "r" are unused as far as I can tell.

Reproducible: Always

Steps to Reproduce:
1. Alt-V
2. S
3. Various mnemonics assigned to sub-items of sort menu
Actual Results:  
Either nothing at all, or menu item in View menu that matches step 3 is selected.

Expected Results:  
Select a sort option.

Comment 1

[[:Aureliano Buendía]]

WFM here on 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3pre) Gecko/20090810 Lightning/1.0pre Shredder/3.0b4pre ID:20090810161308

ALT-V + S highlit only "statusBar" item.

Could you try to see if it still happens with
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-1.9.1/ ?

Comment 2

[Wayne Mery (:wsmwk)]

I see this with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.3pre) Gecko/20090811 Shredder/3.0b4pre.  Gary, do you see this on non-windows?

  Aureliano, what does your "sort by" map to?

personally i'd like to see status bar move to toolbars menu

Comment 3

[[:Aureliano Buendía]]

(In reply to comment #2)

>   Aureliano, what does your "sort by" map to?

I'm sorry, I'm wrong: ALT-V + S highlit FIRST view--> status bar, but also view-->sort by has "S" key accelerator.

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #2)
> I see this with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.3pre)
> Gecko/20090811 Shredder/3.0b4pre.  Gary, do you see this on non-windows?

Macs don't have access keys on menus - only keyboard shortcuts. Haven't yet tested on Linux though.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 394660 [details] [diff] [review]
proposed fix

just putting my plus on this anyway :)

Comment 7

[Phil Ringnalda (:philor)]

Comment on attachment 394660 [details] [diff] [review]
proposed fix

Nice spacing in that file - wonder whether it was chosen with a dartboard, or by cutting a deck of cards...

Comment 8

[Magnus Melin [:mkmelin]]

changeset:   3447:784c977804c8
http://hg.mozilla.org/comm-central/rev/784c977804c8

->FIXED