508202 - Cannot build on Vista x64 with VC9 + MozillaBuild1.4 after bug 505289

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: fix

See comment 28.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

After I removed the whitespaces in requestedExecutionLevel, I've never looked the error.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #0)
> See comment 28.

oops, bug 505289 comment 28.

Comment 3

[Masatoshi Kimura [:emk]]

Comment on attachment 392442 [details] [diff] [review]
fix

OK, it definitely solved double requestedExecutionLevel problem.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 392442 [details] [diff] [review]
fix

I don't understand why this would fix it, but it looks harmless, and I'll take your and Masatoshi's word for it.

Comment 5

[Rob Arnold [:robarnold]]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/285a17333d0b

Comment 6

[Masatoshi Kimura [:emk]]

For reference, let me explain what happens here.
MSVC9 linker tries to find requestedExecutionLevel from an existing manifest. If it is not found, the linker will add it.
The linker fails to find an existing requestedExecutionLevel if it contains white spaces. So it will add another requestedExecutionLevel because the linker thinks it is not present yet. Vista/7 consider the manifest is broken and ignore it if it contains duplicate requestedExecutionLevel.
We have two options to deal with the problem:
1. Add /MANIFESTUAC:NO linker flag as bug 419665 did.
2. Remove extra white spaces from requestedExecutionLevel as this bug did.

Comment 7

[(not currently active) Ted Mielczarek]

Thanks for the explanation. This seems like the simplest fix, then.