508223 - Favicons in All Tabs dropdown not shown if menus_have_icons=false

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Andreas Nilsson (:andreasn)]

Attachment: screenshot (top part filed as Bug 508221)

Related to bug 504275, GNOME recently set menus_have_icons to false by default.
[1] What this means is that menus will no longer show icons, including the tabs dropdown.
However, bookmarks (and favicons) are exceptions that should use icons
according to the guidelines [2] and those can be set to "always-show-icons"
property (GtkImageMenuItem).

1. http://bugzilla.gnome.org/show_bug.cgi?id=557469
2. http://bugzilla.gnome.org/show_bug.cgi?id=588668

Comment 1

[Martin McNickle]

Attachment: patch

Overrides default style and shows icons in the tab dropdown.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 397052 [details] [diff] [review]
patch

> /* Bookmarks override the "images-in-menus" metric in xul.css */
> .bookmark-item > .menu-iconic-left {
>   visibility: inherit;
> }
>+
>+.alltabs-item > .menu-iconic-left {
>+  visibility: inherit;
>+}

These two rules can be combined:

/* favicons override the "images-in-menus" metric in xul.css */
.alltabs-item > .menu-iconic-left,
.bookmark-item > .menu-iconic-left {
  visibility: inherit;
}

Comment 3

[Martin McNickle]

Attachment: combined rules

Comment 4

[Dão Gottwald [:dao]]

Actually, this belongs in tabbrowser.css. I'll move it there before landing. Thanks Martin!

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/ad18d068d42e

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 397052 [details] [diff] [review]
patch

a192=beltzner

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/145e56834616

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on trunk and 1.9.2 with:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20090920 Minefield/3.7a1pre ID:20090920031240

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a2pre) Gecko/20090921 Namoroka/3.6a2pre ID:20090921035151

Given bug 504275 a fix on 1.9.1 would be needed too.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 397052 [details] [diff] [review]
patch

Probably too late for 3.5.4. But asking anyway. Patch is simple and applies well to 1.9.1.

Comment 10

[Samuel Sidler (old account; do not CC)]

Comment on attachment 397052 [details] [diff] [review]
patch

There's no reason for us to take this at this point. Linux distros can fix it on their side or wait for 3.6.