504275 - Bookmark favicon images with menus_have_icons=false

Status: RESOLVED FIXED

Description

[Michael Monreal [:micmon]]

GNOME has decided¹ to set menus_have_icons to false as a default for the coming 2.28 release. What this means is that menus will no longer show icons.

This however also affects bookmark menus in Firefox. So, menu items which are bookmarks with favicon (and only those) should set the "always-show-icons" property (GtkImageMenuItem).

Can this change be done in the 3.5 branch? As far as I know, setting the property does not have a negative effect for users of menus_have_icons=true

[1] http://bugzilla.gnome.org/show_bug.cgi?id=557469

Comment 1

[Michael Ventnor]

So what's the problem? You're saying that bookmark menu items should always have an icon?

Comment 2

[Michael Ventnor]

And if that's the case, should folders/smart folders that are submenus also show icons?

This really seems like an odd inconsistency from the GNOME folks, almost like a begrudging admission that icons do actually work ;-)

Comment 3

[Michael Monreal [:micmon]]

Well, not talking about my own preferences or feelings regarding this change here... :)

But the GNOME HIG explictly mentions¹ this case: "Show icons for bookmark entries on the Bookmarks menu that indicate the type of the bookmark, even if the user has globally turned off icons for other menu items on the desktop."

As I read this, smart bookmarks should indicate that they are smart bookmarks. I don't think "smart" folders are covered by this.

[1] http://www.gnome.org/~calum/hig-devel/menus-standard.html#menu-standard-bookmarks

Comment 4

[Michael Ventnor]

Created attachment 388841 [details] [diff] [review]
Patch

This has buckley's chance of making 3.5 (though you can try and request it, I guess), and if the schedule plans did change as proposed in the last meeting, then we only have 1 week for it to be certain of making 3.6.

Comment 5

[Dão Gottwald [::dao]]

Comment on attachment 388841 [details] [diff] [review]
Patch

Can you put this in browser/base/content/browser.css with %ifdef MOZ_WIDGET_GTK2? That would be consistent with xul.css.

Comment 6

[Michael Ventnor]

Created attachment 388881 [details] [diff] [review]
Patch

Sure.

Comment 7

[Michael Monreal [:micmon]]

(In reply to comment #4)
> This has buckley's chance of making 3.5 (though you can try and request it, I
> guess), and if the schedule plans did change as proposed in the last meeting,
> then we only have 1 week for it to be certain of making 3.6.

When is 3.6 due out then? GNOME 2.28 is set for a Sep 23 release and Ubuntu will have a release shortly after that.

Comment 8

[Michael Ventnor]

Assuming they are planning to quickly stabilize 1.9.2 in order to ship Fennec 1.0 on it (it's not 100% confirmed), the plan is to ship 3.6 "this fall" according to recent meeting notes.

Comment 9

[Michael Monreal [:micmon]]

Ok... "this fall" sounds like Fedora 12 would ship it (or some RC, as they did with 3.5) but Ubuntu will probably not. Probably worth asking distributions to ship the patch with 3.5 (if they ship GNOME 2.28).

Comment 10

[Dão Gottwald [::dao]]

http://hg.mozilla.org/mozilla-central/rev/c1840493c832

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 388881 [details] [diff] [review]
Patch

a1912=beltzner

Comment 12

[Dão Gottwald [::dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0592119e3de1

Comment 13

[Anthony Hughes (:ashughes) [QA]]

Is there a way QA can verify this on Firefox 3.5.2 without GNOME 2.28? Do we have to wait until Ubuntu/Fedora become updated?

Comment 14

[Michael Monreal [:micmon]]

Sure, set /desktop/gnome/interface/menus_have_icon to false in gconf or untick the checkbox in Preferences->Appearance->Interface

Comment 15

[Anthony Hughes (:ashughes) [QA]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2

Our menus look the same whether OS Preferences->Appearance->Interface->"Show icons in menus" is enabled or disabled.

Is this expected behaviour?

Comment 16

[Michael Monreal [:micmon]]

Surely not... I think it works for me, though. Using Fx 3.5.1 and the code from the patch in userChrome.css... have you tested if menu icons disappear from other GTK apps?

Comment 17

[Anthony Hughes (:ashughes) [QA]]

I can see the icons disappear from other menus (Applications, Places, System).  In Firefox 3.5.2 they look the same (no matter the pref setting).

Comment 18

[Dão Gottwald [::dao]]

You probably need to restart Firefox (which is suboptimal and might be a bug on its own).

Comment 19

[Anthony Hughes (:ashughes) [QA]]

Created attachment 391988 [details]
Screenshot

Here is a screenshot of what I am seeing.  Notice the icon for Organize Bookmarks is removed when the pref is disabled.  All other icons that were there before are present.  Is this expected?

Comment 20

[Dão Gottwald [::dao]]

Yes.

Comment 21

[Anthony Hughes (:ashughes) [QA]]

Excellent.  Based on that, verified1.9.1.

Comment 22

[Andreas Nilsson (:andreasn)]

Created attachment 392287 [details]
quicksearch and tab dropdown

Seems this also affects the favicons for the quick search box dropdown and tabs dropdown (that both should have icons according to the new guidelines). Should that be filed as a separate bug?

Comment 23

[Dão Gottwald [::dao]]

(In reply to comment #22)
> Should that be filed as a separate bug?

Yes.

Comment 24

[Andreas Nilsson (:andreasn)]

Filed those as Bug 508221 and Bug 508223