50878 - MLK: javascript urls that assert

Status: RESOLVED INVALID

(Core :: Networking, defect, P3)

Description

[Bruce Mitchener]

Build from last night.  Run a javascript: url that asserts.  Got this leak.

         MLK: 11 bytes leaked at 0x21c5340
         This memory was allocated from:
               malloc         [rtlib.o]
               PL_strdup      [strdup.c:30]
               nsCRT::strdup(const char*) [nsCRT.h:172]
               nsSimpleURI::GetPath(char**) [nsSimpleURI.cpp:216]
               nsJSThunk::Open(char**,int*) [nsJSProtocolHandler.cpp:301]
               nsFileTransport::Process() [nsFileTransport.cpp:387]
                          PR_LOG(gFileTransportLog, PR_LOG_DEBUG,
                                 ("nsFileTransport: OPEN_FOR_READ [this=%x %s]",
                                  this, mStreamName.GetBuffer()));
               =>         mStatus = mStreamIO->Open(&mContentType, &mTotalAmount);
                          if (mListener) {
                              nsresult rv = mListener->OnStartRequest(this, mContext);  // always send the start notification
                              if (NS_SUCCEEDED(mStatus))
               nsFileTransport::Run() [nsFileTransport.cpp:361]
               nsThreadPoolRunnable::Run() [nsThread.cpp:689]
               nsThread::Main(void*) [nsThread.cpp:84]
               _pt_root       [ptthread.c:198]
               _thread_start  [libthread.so.1]

Comment 1

[Gagan]

Attachment: patch for mem leak

Comment 2

[Gagan]

Attachment: patch for mem leak

Comment 3

[Gagan]

Hmmm... for some reason this page timedout the first time. Anyway, I am not sure
this could make it for beta3 per our new rules. But this should get picked up on
the next cycle.

Comment 4

[benc]

mass move, v2.
qa to me.

Comment 5

[benc]

-> defaults

Comment 6

[benc]

This is a really old bug, can someone confirm that it still happens or WFM?

Comment 7

[Mikael Parknert]

Can't find nsFileTransport.cpp in lxr, maybe removed or moved to some other
interface?

Comment 8

[benc]

RESOLVED/INVALID:

Mikael: thanks for pointing that out. Can you VERIFY this bug?